* [PATCH] tests/unit: Bump test-replication timeout to 45 seconds
@ 2024-01-25 16:58 Kevin Wolf
2024-01-25 17:05 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2024-01-25 16:58 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, stefanha, peter.maydell, berrange, thuth, qemu-devel
We're seeing timeouts for this test on CI runs (specifically for
ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the
successful runs take about 27 or 28 seconds, which is not very far from
the 30 seconds timeout.
Bump the timeout a bit to make failure less likely even on this CI host.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/unit/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/unit/meson.build b/tests/unit/meson.build
index 0659532122..db6398a0f4 100644
--- a/tests/unit/meson.build
+++ b/tests/unit/meson.build
@@ -175,7 +175,8 @@ slow_tests = {
'test-aio-multithread' : 120,
'test-crypto-block' : 300,
'test-crypto-tlscredsx509': 45,
- 'test-crypto-tlssession': 45
+ 'test-crypto-tlssession': 45,
+ 'test-replication': 45,
}
foreach test_name, extra: tests
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tests/unit: Bump test-replication timeout to 45 seconds
2024-01-25 16:58 [PATCH] tests/unit: Bump test-replication timeout to 45 seconds Kevin Wolf
@ 2024-01-25 17:05 ` Thomas Huth
2024-01-25 17:15 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2024-01-25 17:05 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: stefanha, peter.maydell, berrange, qemu-devel
On 25/01/2024 17.58, Kevin Wolf wrote:
> We're seeing timeouts for this test on CI runs (specifically for
> ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the
> successful runs take about 27 or 28 seconds, which is not very far from
> the 30 seconds timeout.
>
> Bump the timeout a bit to make failure less likely even on this CI host.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/unit/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/meson.build b/tests/unit/meson.build
> index 0659532122..db6398a0f4 100644
> --- a/tests/unit/meson.build
> +++ b/tests/unit/meson.build
> @@ -175,7 +175,8 @@ slow_tests = {
> 'test-aio-multithread' : 120,
> 'test-crypto-block' : 300,
> 'test-crypto-tlscredsx509': 45,
> - 'test-crypto-tlssession': 45
> + 'test-crypto-tlssession': 45,
> + 'test-replication': 45,
> }
>
> foreach test_name, extra: tests
I'd maybe even bump it to 60 seconds, just to be on the safe side.
Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tests/unit: Bump test-replication timeout to 45 seconds
2024-01-25 17:05 ` Thomas Huth
@ 2024-01-25 17:15 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2024-01-25 17:15 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-block, stefanha, peter.maydell, berrange, qemu-devel
Am 25.01.2024 um 18:05 hat Thomas Huth geschrieben:
> On 25/01/2024 17.58, Kevin Wolf wrote:
> > We're seeing timeouts for this test on CI runs (specifically for
> > ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the
> > successful runs take about 27 or 28 seconds, which is not very far from
> > the 30 seconds timeout.
> >
> > Bump the timeout a bit to make failure less likely even on this CI host.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > tests/unit/meson.build | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/unit/meson.build b/tests/unit/meson.build
> > index 0659532122..db6398a0f4 100644
> > --- a/tests/unit/meson.build
> > +++ b/tests/unit/meson.build
> > @@ -175,7 +175,8 @@ slow_tests = {
> > 'test-aio-multithread' : 120,
> > 'test-crypto-block' : 300,
> > 'test-crypto-tlscredsx509': 45,
> > - 'test-crypto-tlssession': 45
> > + 'test-crypto-tlssession': 45,
> > + 'test-replication': 45,
> > }
> > foreach test_name, extra: tests
>
> I'd maybe even bump it to 60 seconds, just to be on the safe side.
Works for me, too. I can change it before sending a pull request.
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Thanks!
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-25 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-25 16:58 [PATCH] tests/unit: Bump test-replication timeout to 45 seconds Kevin Wolf
2024-01-25 17:05 ` Thomas Huth
2024-01-25 17:15 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).