* [PATCH] iotests/264: Use iotests.sock_dir for socket creation
@ 2024-01-25 13:52 Andrey Drobyshev
2024-01-25 20:35 ` Eric Blake
2024-01-26 10:17 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Andrey Drobyshev @ 2024-01-25 13:52 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, hreitz, kwolf, eblake, andrey.drobyshev, den
If socket path is too long (longer than 108 bytes), socket can't be
opened. This might lead to failure when test dir path is long enough.
Make sure socket is created in iotests.sock_dir to avoid such a case.
This commit basically aligns iotests/264 with the rest of iotests.
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
---
tests/qemu-iotests/264 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264
index c532ccd809..c6ba2754e2 100755
--- a/tests/qemu-iotests/264
+++ b/tests/qemu-iotests/264
@@ -25,7 +25,8 @@ import os
import iotests
from iotests import qemu_img_create, file_path, qemu_nbd_popen
-disk_a, disk_b, nbd_sock = file_path('disk_a', 'disk_b', 'nbd-sock')
+disk_a, disk_b = file_path('disk_a', 'disk_b')
+nbd_sock = file_path('nbd-sock', base_dir=iotests.sock_dir)
nbd_uri = 'nbd+unix:///?socket=' + nbd_sock
wait_limit = 3.0
wait_step = 0.2
--
2.39.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iotests/264: Use iotests.sock_dir for socket creation
2024-01-25 13:52 [PATCH] iotests/264: Use iotests.sock_dir for socket creation Andrey Drobyshev
@ 2024-01-25 20:35 ` Eric Blake
2024-01-26 10:17 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2024-01-25 20:35 UTC (permalink / raw)
To: Andrey Drobyshev; +Cc: qemu-block, qemu-devel, hreitz, kwolf, den
On Thu, Jan 25, 2024 at 03:52:37PM +0200, Andrey Drobyshev wrote:
> If socket path is too long (longer than 108 bytes), socket can't be
> opened. This might lead to failure when test dir path is long enough.
> Make sure socket is created in iotests.sock_dir to avoid such a case.
>
> This commit basically aligns iotests/264 with the rest of iotests.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> ---
> tests/qemu-iotests/264 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264
> index c532ccd809..c6ba2754e2 100755
> --- a/tests/qemu-iotests/264
> +++ b/tests/qemu-iotests/264
> @@ -25,7 +25,8 @@ import os
> import iotests
> from iotests import qemu_img_create, file_path, qemu_nbd_popen
>
> -disk_a, disk_b, nbd_sock = file_path('disk_a', 'disk_b', 'nbd-sock')
> +disk_a, disk_b = file_path('disk_a', 'disk_b')
> +nbd_sock = file_path('nbd-sock', base_dir=iotests.sock_dir)
> nbd_uri = 'nbd+unix:///?socket=' + nbd_sock
> wait_limit = 3.0
> wait_step = 0.2
> --
> 2.39.3
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iotests/264: Use iotests.sock_dir for socket creation
2024-01-25 13:52 [PATCH] iotests/264: Use iotests.sock_dir for socket creation Andrey Drobyshev
2024-01-25 20:35 ` Eric Blake
@ 2024-01-26 10:17 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2024-01-26 10:17 UTC (permalink / raw)
To: Andrey Drobyshev; +Cc: qemu-block, qemu-devel, hreitz, eblake, den
Am 25.01.2024 um 14:52 hat Andrey Drobyshev geschrieben:
> If socket path is too long (longer than 108 bytes), socket can't be
> opened. This might lead to failure when test dir path is long enough.
> Make sure socket is created in iotests.sock_dir to avoid such a case.
>
> This commit basically aligns iotests/264 with the rest of iotests.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-26 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-25 13:52 [PATCH] iotests/264: Use iotests.sock_dir for socket creation Andrey Drobyshev
2024-01-25 20:35 ` Eric Blake
2024-01-26 10:17 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).