qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH 08/10] cxl: Clean up includes
Date: Fri, 26 Jan 2024 23:41:52 +0800	[thread overview]
Message-ID: <ZbPSwMopXfEi0IX6@intel.com> (raw)
In-Reply-To: <20240125163408.1595135-9-peter.maydell@linaro.org>

On Thu, Jan 25, 2024 at 04:34:06PM +0000, Peter Maydell wrote:
> Date: Thu, 25 Jan 2024 16:34:06 +0000
> From: Peter Maydell <peter.maydell@linaro.org>
> Subject: [PATCH 08/10] cxl: Clean up includes
> X-Mailer: git-send-email 2.34.1
> 
> This commit was created with scripts/clean-includes.
> 
> All .c should include qemu/osdep.h first.  The script performs three
> related cleanups:
> 
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c  already includes
>   it.  Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
>   Drop these, too.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/cxl/cxl-events.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

> 
> diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c
> index bee6dfaf148..affcf8a34dd 100644
> --- a/hw/cxl/cxl-events.c
> +++ b/hw/cxl/cxl-events.c
> @@ -7,11 +7,9 @@
>   * COPYING file in the top-level directory.
>   */
>  
> -#include <stdint.h>
> -
>  #include "qemu/osdep.h"
> +
>  #include "qemu/bswap.h"
> -#include "qemu/typedefs.h"
>  #include "qemu/error-report.h"
>  #include "hw/pci/msi.h"
>  #include "hw/pci/msix.h"
> -- 
> 2.34.1
> 
> 


  parent reply	other threads:[~2024-01-26 15:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 16:33 [PATCH 00/10] Clean up includes Peter Maydell
2024-01-25 16:33 ` [PATCH 01/10] scripts/clean-includes: Update exclude list Peter Maydell
2024-01-25 16:34 ` [PATCH 02/10] hyperv: Clean up includes Peter Maydell
2024-01-26 15:45   ` Zhao Liu
2024-01-27  5:04   ` Richard Henderson
2024-01-25 16:34 ` [PATCH 03/10] disas/riscv: " Peter Maydell
2024-01-25 16:59   ` Philippe Mathieu-Daudé
2024-01-26 15:44   ` Zhao Liu
2024-01-27  5:05   ` Richard Henderson
2024-01-31 23:43   ` Alistair Francis
2024-01-25 16:34 ` [PATCH 04/10] aspeed: " Peter Maydell
2024-01-25 16:59   ` Philippe Mathieu-Daudé
2024-01-26 15:39   ` Zhao Liu
2024-01-26 15:38     ` Peter Maydell
2024-01-27  5:05   ` Richard Henderson
2024-01-25 16:34 ` [PATCH 05/10] acpi: " Peter Maydell
2024-01-25 17:01   ` Philippe Mathieu-Daudé
2024-01-26 15:40   ` Zhao Liu
2024-01-27  5:06   ` Richard Henderson
2024-01-25 16:34 ` [PATCH 06/10] m68k: " Peter Maydell
2024-01-25 17:00   ` Philippe Mathieu-Daudé
2024-01-26 15:43   ` Thomas Huth
2024-01-26 15:44   ` Zhao Liu
2024-01-25 16:34 ` [PATCH 07/10] include: " Peter Maydell
2024-01-26 15:43   ` Zhao Liu
2024-01-25 16:34 ` [PATCH 08/10] cxl: " Peter Maydell
2024-01-25 17:00   ` Philippe Mathieu-Daudé
2024-01-26 15:41   ` Zhao Liu [this message]
2024-01-29 10:35   ` Jonathan Cameron via
2024-01-25 16:34 ` [PATCH 09/10] riscv: " Peter Maydell
2024-01-25 17:00   ` Philippe Mathieu-Daudé
2024-01-26 15:41   ` Zhao Liu
2024-01-30  0:43   ` Alistair Francis
2024-01-25 16:34 ` [PATCH 10/10] misc: " Peter Maydell
2024-01-26 15:47   ` Zhao Liu
2024-01-27  5:53 ` [PATCH 00/10] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbPSwMopXfEi0IX6@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).