qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH v2 0/9] hw/core: Cleanup and reorder headers
Date: Mon, 29 Jan 2024 17:35:58 +0800	[thread overview]
Message-ID: <ZbdxfiOaVu3U+sec@intel.com> (raw)
In-Reply-To: <20240116074647.3644821-1-zhao1.liu@linux.intel.com>

Hi Philippe,

Thanks for picking the 1st patch. Could you take time for further review
on other patches?

Thanks,
Zhao

On Tue, Jan 16, 2024 at 03:46:38PM +0800, Zhao Liu wrote:
> Date: Tue, 16 Jan 2024 15:46:38 +0800
> From: Zhao Liu <zhao1.liu@linux.intel.com>
> Subject: [PATCH v2 0/9] hw/core: Cleanup and reorder headers
> X-Mailer: git-send-email 2.34.1
> 
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Identify unused headers by full compilation (tested by "./configure" and
> then "make") and manually checking if it is a direct inclusion.
> 
> Then reorder headers in alphabetical order.
> 
> In addition, update a file entry in MAINTAINERS file.
> 
> ---
> Changelog:
> 
> v1: Per Peter and Philippe's comments in v1, keep directly included
>     headers to avoid implicit header inclusions [1].
> 
> [1]: https://lore.kernel.org/qemu-devel/06d4179f-76b8-42f0-b147-f4bc2d1f06bd@linaro.org/#t
> 
> ---
> Zhao Liu (9):
>   MAINTAINERS: Update hw/core/cpu.c entry
>   hw/core: Cleanup unused included headers in cpu-common.c
>   hw/core: Reorder included headers in cpu-common.c
>   hw/core: Reorder included headers in cpu-sysemu.c
>   hw/core: Cleanup unused included header in machine-qmp-cmds.c
>   hw/core: Reorder included header in machine.c
>   hw/core: Reorder included headers in null-machine.c
>   hw/core: Cleanup unused included headers in numa.c
>   hw/core: Reorder included headers in numa.c
> 
>  MAINTAINERS                |  3 ++-
>  hw/core/cpu-common.c       | 17 +++++++----------
>  hw/core/cpu-sysemu.c       |  3 ++-
>  hw/core/machine-qmp-cmds.c |  2 +-
>  hw/core/machine.c          | 21 +++++++++++----------
>  hw/core/null-machine.c     |  5 +++--
>  hw/core/numa.c             | 22 ++++++++++------------
>  7 files changed, 36 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 
> 


      parent reply	other threads:[~2024-01-29  9:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  7:46 [PATCH v2 0/9] hw/core: Cleanup and reorder headers Zhao Liu
2024-01-16  7:46 ` [PATCH v2 1/9] MAINTAINERS: Update hw/core/cpu.c entry Zhao Liu
2024-01-16  7:46 ` [PATCH v2 2/9] hw/core: Cleanup unused included headers in cpu-common.c Zhao Liu
2024-01-16  7:46 ` [PATCH v2 3/9] hw/core: Reorder " Zhao Liu
2024-01-16  7:46 ` [PATCH v2 4/9] hw/core: Reorder included headers in cpu-sysemu.c Zhao Liu
2024-01-16  7:46 ` [PATCH v2 5/9] hw/core: Cleanup unused included header in machine-qmp-cmds.c Zhao Liu
2024-01-16  7:46 ` [PATCH v2 6/9] hw/core: Reorder included header in machine.c Zhao Liu
2024-01-16  7:46 ` [PATCH v2 7/9] hw/core: Reorder included headers in null-machine.c Zhao Liu
2024-01-16  7:46 ` [PATCH v2 8/9] hw/core: Cleanup unused included headers in numa.c Zhao Liu
2024-01-16  7:46 ` [PATCH v2 9/9] hw/core: Reorder " Zhao Liu
2024-01-29  9:35 ` Zhao Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbdxfiOaVu3U+sec@intel.com \
    --to=zhao1.liu@linux.intel.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).