qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>
Cc: qemu-devel@nongnu.org, Xiaoling Song <xiaoling.song@intel.com>,
	Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases
Date: Mon, 29 Jan 2024 17:38:24 +0800	[thread overview]
Message-ID: <ZbdyEDhz/pjuZNVE@intel.com> (raw)
In-Reply-To: <20240118144857.2124034-1-zhao1.liu@linux.intel.com>

Hi Philippe,

A kindly ping.

Thanks,
Zhao

On Thu, Jan 18, 2024 at 10:48:49PM +0800, Zhao Liu wrote:
> Date: Thu, 18 Jan 2024 22:48:49 +0800
> From: Zhao Liu <zhao1.liu@linux.intel.com>
> Subject: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology
>  test cases
> X-Mailer: git-send-email 2.34.1
> 
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Hi list,
> 
> Currently, test-smp-parse lacks the following cases:
> * The case to cover drawer and book parameters parsing in -smp.
> * The case to cover the full topology (with total 7 levels) to ensure
>   that the topology-related calculations are correct.
> * The case to check smp_props.has_clusters of MachineClass.
> 
> Thus, add the above cases to improve test coverage.
> 
> In addition, people is trying to bump max_cpus to 4096 for PC machine
> [1]. Without considering other changes, it's only a matter of time
> before the maximum CPUs is raised. Therefore, aslo bump max_cpus to 4096
> in -smp related test cases as a start.
> 
> [1]: https://lore.kernel.org/qemu-devel/20231208122611.32311-1-anisinha@redhat.com/
> 
> Regards,
> Zhao
> 
> ---
> Zhao Liu (8):
>   tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology
>     case
>   tests/unit/test-smp-parse.c: Bump max_cpus to 4096
>   tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer
>   tests/unit/test-smp-parse.c: Test "books" parameter in -smp
>   tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp
>   tests/unit/test-smp-parse.c: Test "drawers" and "books" combination
>     case
>   tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy
>   tests/unit/test-smp-parse.c: Test smp_props.has_clusters
> 
>  tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 494 insertions(+), 21 deletions(-)
> 
> -- 
> 2.34.1
> 
> 


  parent reply	other threads:[~2024-01-29  9:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 14:48 [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases Zhao Liu
2024-01-18 14:48 ` [PATCH 1/8] tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology case Zhao Liu
2024-03-01  7:37   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 2/8] tests/unit/test-smp-parse.c: Bump max_cpus to 4096 Zhao Liu
2024-03-01  7:40   ` Thomas Huth
2024-03-01  7:59     ` Zhao Liu
2024-01-18 14:48 ` [PATCH 3/8] tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer Zhao Liu
2024-03-01  7:49   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 4/8] tests/unit/test-smp-parse.c: Test "books" parameter in -smp Zhao Liu
2024-03-01  7:52   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 5/8] tests/unit/test-smp-parse.c: Test "drawers" " Zhao Liu
2024-03-01  7:56   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 6/8] tests/unit/test-smp-parse.c: Test "drawers" and "books" combination case Zhao Liu
2024-01-18 14:48 ` [PATCH 7/8] tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy Zhao Liu
2024-03-01  7:59   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 8/8] tests/unit/test-smp-parse.c: Test smp_props.has_clusters Zhao Liu
2024-03-01  8:01   ` Thomas Huth
2024-01-29  2:37 ` [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases Song, Xiaoling
2024-01-29  9:38 ` Zhao Liu [this message]
2024-02-21  6:47   ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbdyEDhz/pjuZNVE@intel.com \
    --to=zhao1.liu@linux.intel.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=xiaoling.song@intel.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).