From: Peter Xu <peterx@redhat.com>
To: Hao Xiang <hao.xiang@bytedance.com>
Cc: qemu-devel@nongnu.org, farosas@suse.de
Subject: Re: [PATCH 1/6] migration/multifd: Add new migration option multifd-zero-page.
Date: Wed, 7 Feb 2024 11:44:52 +0800 [thread overview]
Message-ID: <ZcL8tLF7tmD0JpVV@x1n> (raw)
In-Reply-To: <20240206231908.1792529-2-hao.xiang@bytedance.com>
On Tue, Feb 06, 2024 at 11:19:03PM +0000, Hao Xiang wrote:
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 819708321d..ff033a0344 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -874,6 +874,11 @@
> # @mode: Migration mode. See description in @MigMode. Default is 'normal'.
> # (Since 8.2)
> #
> +# @multifd-zero-page: Multifd zero page checking. If the parameter is true,
> +# zero page checking is done on the multifd sender thread. If the parameter
> +# is false, zero page checking is done on the migration main thread. Default
> +# is set to true. (Since 9.0)
I replied somewhere before on this, but I can try again..
Do you think it'll be better to introduce a generic parameter for zero page
detection?
- "none" if disabled,
- "legacy" for main thread,
- "multifd" for multifd (software-based).
A string could work, but maybe cleaner to introduce
@MigrationZeroPageDetector enum?
When you add more, you can keep extending that with the single field
("multifd-dsa", etc.).
--
Peter Xu
next prev parent reply other threads:[~2024-02-07 3:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 23:19 [PATCH 0/6] Introduce multifd zero page checking Hao Xiang
2024-02-06 23:19 ` [PATCH 1/6] migration/multifd: Add new migration option multifd-zero-page Hao Xiang
2024-02-07 3:44 ` Peter Xu [this message]
2024-02-08 0:49 ` [External] " Hao Xiang
2024-02-06 23:19 ` [PATCH 2/6] migration/multifd: Add zero pages and zero bytes counter to migration status interface Hao Xiang
2024-02-07 4:13 ` Peter Xu
2024-02-07 4:37 ` Peter Xu
2024-02-07 8:41 ` Jiri Denemark
2024-02-07 23:44 ` [External] " Hao Xiang
2024-02-08 2:51 ` Peter Xu
2024-02-06 23:19 ` [PATCH 3/6] migration/multifd: Support for zero pages transmission in multifd format Hao Xiang
2024-02-07 4:25 ` Peter Xu
2024-02-08 19:03 ` [External] " Hao Xiang
2024-02-06 23:19 ` [PATCH 4/6] migration/multifd: Zero page transmission on the multifd thread Hao Xiang
2024-02-07 4:45 ` Peter Xu
2024-02-06 23:19 ` [PATCH 5/6] migration/multifd: Enable zero page checking from multifd threads Hao Xiang
2024-02-06 23:19 ` [PATCH 6/6] migration/multifd: Add a new migration test case for legacy zero page checking Hao Xiang
2024-02-07 3:39 ` [PATCH 0/6] Introduce multifd " Peter Xu
2024-02-08 0:47 ` [External] " Hao Xiang
2024-02-08 2:36 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcL8tLF7tmD0JpVV@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=hao.xiang@bytedance.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).