From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A483C4828F for ; Wed, 7 Feb 2024 08:35:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXdOg-000758-M8; Wed, 07 Feb 2024 03:35:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXdOd-00073u-Fv for qemu-devel@nongnu.org; Wed, 07 Feb 2024 03:35:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXdOa-0000P6-Qy for qemu-devel@nongnu.org; Wed, 07 Feb 2024 03:35:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707294904; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TmBZlsHYeLSzYpMad6UfkZpFXoY4J75dpO7uIle/tj0=; b=Na376CgxazpjMsbZ8lTCHOiKzHTDP5IOTLnT5ZKgJLem8eIfo4vyhhYNovY8mivhjZctZV vR0AUVMlBPSGTWQEHciEvDL2Wv+3v+R8LsnPqKoF13k6U9Kas/B7SCpMsE5ZPFGKJZsA6l 2cUNVLLF44elJtW66xqptZ/xrcwy+tI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-5_ogD1YPM6WLNzzaLnq2ZA-1; Wed, 07 Feb 2024 03:34:59 -0500 X-MC-Unique: 5_ogD1YPM6WLNzzaLnq2ZA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9306083722E; Wed, 7 Feb 2024 08:34:58 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D0B8492BC6; Wed, 7 Feb 2024 08:34:55 +0000 (UTC) Date: Wed, 7 Feb 2024 08:34:53 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, arei.gonglei@huawei.com, eblake@redhat.com, eduardo@habkost.net, fan.ni@samsung.com, farosas@suse.de, hreitz@redhat.com, jasowang@redhat.com, jiri@resnulli.us, jonathan.cameron@huawei.com, kkostiuk@redhat.com, kraxel@redhat.com, kwolf@redhat.com, lukasstraub2@web.de, marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com, michael.roth@amd.com, mst@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, peterx@redhat.com, philmd@linaro.org, pizhenwei@bytedance.com, qemu-block@nongnu.org, stefanb@linux.ibm.com, wangyanan55@huawei.com Subject: Re: [PATCH 09/15] qga/qapi-schema: Plug trivial documentation holes Message-ID: References: <20240205074709.3613229-1-armbru@redhat.com> <20240205074709.3613229-10-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240205074709.3613229-10-armbru@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.294, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 05, 2024 at 08:47:03AM +0100, Markus Armbruster wrote: > Add missing return member documentation of guest-get-disks, > guest-get-devices, guest-get-diskstats, and guest-get-cpustats. > > The NVMe SMART information returned by guest-getdisks remains > undocumented. Add a TODO there. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé > @@ -978,7 +974,7 @@ > # > # Disk type related smart information. > # > -# - @nvme: NVMe disk smart > +# @type: disk bus type > # > # Since: 7.1 > ## Fun, so not only were the fields that exist not documented, but we've documented fields which don't exist. > @@ -1780,7 +1784,7 @@ > # > # Get statistics of each CPU in millisecond. > # > -# - @linux: Linux style CPU statistics > +# @type: guest operating system > # > # Since: 7.1 > ## And more things which don't exist ! With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|