From: Peter Xu <peterx@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 13/14] migration: Use migrate_has_error() in close_return_path_on_source()
Date: Thu, 8 Feb 2024 13:52:32 +0800 [thread overview]
Message-ID: <ZcRsIAt-FA29yLR7@x1n> (raw)
In-Reply-To: <20240207133347.1115903-14-clg@redhat.com>
On Wed, Feb 07, 2024 at 02:33:46PM +0100, Cédric Le Goater wrote:
> close_return_path_on_source() retrieves the migration error from the
> the QEMUFile '->to_dst_file' to know if a shutdown is required. This
> shutdown is required to exit the return-path thread. However, in
> migrate_fd_cleanup(), '->to_dst_file' is cleaned up before calling
> close_return_path_on_source() and the shutdown is never performed,
> leaving the source and destination waiting for an event to occur.
>
> Avoid relying on '->to_dst_file' and use migrate_has_error() instead.
>
> Suggested-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2024-02-08 5:53 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 13:33 [PATCH 00/14] migration: Improve error reporting Cédric Le Goater
2024-02-07 13:33 ` [PATCH 01/14] migration: Add Error** argument to .save_setup() handler Cédric Le Goater
2024-02-07 20:11 ` Philippe Mathieu-Daudé
2024-02-08 13:27 ` Cédric Le Goater
2024-02-08 4:26 ` Peter Xu
2024-02-12 8:36 ` Avihai Horon
2024-02-12 14:49 ` Cédric Le Goater
2024-02-12 15:57 ` Avihai Horon
2024-02-07 13:33 ` [PATCH 02/14] migration: Add Error** argument to .load_setup() handler Cédric Le Goater
2024-02-07 20:12 ` Philippe Mathieu-Daudé
2024-02-08 4:30 ` Peter Xu
2024-02-09 9:35 ` Cédric Le Goater
2024-02-07 13:33 ` [PATCH 03/14] memory: Add Error** argument to .log_global*() handlers Cédric Le Goater
2024-02-08 5:48 ` Peter Xu
2024-02-09 10:14 ` Cédric Le Goater
2024-02-12 8:43 ` Avihai Horon
2024-02-12 16:36 ` Cédric Le Goater
2024-02-08 15:59 ` Philippe Mathieu-Daudé
2024-02-07 13:33 ` [PATCH 04/14] migration: Modify ram_init_bitmaps() to report dirty tracking errors Cédric Le Goater
2024-02-07 20:15 ` Philippe Mathieu-Daudé
2024-02-12 8:51 ` Avihai Horon
2024-02-12 16:37 ` Cédric Le Goater
2024-02-07 13:33 ` [PATCH 05/14] vfio: Add Error** argument to .set_dirty_page_tracking() handler Cédric Le Goater
2024-02-07 20:16 ` Philippe Mathieu-Daudé
2024-02-07 13:33 ` [PATCH 06/14] vfio: Add Error** argument to vfio_devices_dma_logging_start() Cédric Le Goater
2024-02-07 20:17 ` Philippe Mathieu-Daudé
2024-02-07 13:33 ` [PATCH 07/14] vfio: Add Error** argument to vfio_devices_dma_logging_stop() Cédric Le Goater
2024-02-07 20:18 ` Philippe Mathieu-Daudé
2024-02-07 13:33 ` [PATCH 08/14] vfio: Use new Error** argument in vfio_save_setup() Cédric Le Goater
2024-02-07 20:21 ` Philippe Mathieu-Daudé
2024-02-12 9:17 ` Avihai Horon
2024-02-12 17:54 ` Cédric Le Goater
2024-02-13 13:57 ` Avihai Horon
2024-02-07 13:33 ` [PATCH 09/14] vfio: Add Error** argument to .vfio_save_config() handler Cédric Le Goater
2024-02-07 20:22 ` Philippe Mathieu-Daudé
2024-02-12 9:21 ` Avihai Horon
2024-02-07 13:33 ` [PATCH 10/14] vfio: Also trace event failures in vfio_save_complete_precopy() Cédric Le Goater
2024-02-07 13:33 ` [PATCH 11/14] vfio: Extend vfio_set_migration_error() with Error* argument Cédric Le Goater
2024-02-07 20:25 ` Philippe Mathieu-Daudé
2024-02-12 9:35 ` Avihai Horon
2024-02-16 13:12 ` Cédric Le Goater
2024-02-07 13:33 ` [PATCH 12/14] migration: Report error when shutdown fails Cédric Le Goater
2024-02-07 20:26 ` Philippe Mathieu-Daudé
2024-02-08 5:52 ` Peter Xu
2024-02-07 13:33 ` [PATCH 13/14] migration: Use migrate_has_error() in close_return_path_on_source() Cédric Le Goater
2024-02-08 5:52 ` Peter Xu [this message]
2024-02-08 13:07 ` Fabiano Rosas
2024-02-08 13:45 ` Cédric Le Goater
2024-02-08 13:57 ` Fabiano Rosas
2024-02-12 13:03 ` Cédric Le Goater
2024-02-14 16:00 ` Fabiano Rosas
2024-02-16 15:17 ` Cédric Le Goater
2024-02-23 4:14 ` Peter Xu
2024-02-07 13:33 ` [RFC PATCH 14/14] migration: Fix return-path thread exit Cédric Le Goater
2024-02-08 5:57 ` Peter Xu
2024-02-12 16:04 ` Cédric Le Goater
2024-02-23 4:25 ` Peter Xu
2024-02-08 13:29 ` Fabiano Rosas
2024-02-12 15:44 ` Cédric Le Goater
2024-02-14 20:35 ` Fabiano Rosas
2024-02-16 15:08 ` Cédric Le Goater
2024-02-16 17:35 ` Fabiano Rosas
2024-02-23 4:31 ` Peter Xu
2024-02-23 14:05 ` Fabiano Rosas
2024-02-26 8:44 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcRsIAt-FA29yLR7@x1n \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).