From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Yong Huang <yong.huang@smartx.com>,
qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment
Date: Wed, 28 Feb 2024 11:30:00 +0000 [thread overview]
Message-ID: <Zd8ZOHJxhgrmbIWc@redhat.com> (raw)
In-Reply-To: <Zd8IQShNrGeXEnLz@redhat.com>
On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote:
> Until now, @size has been mandatory for creating images with every
> driver. Maybe we should even have put it into BlockdevCreateOptions's
> base, because without a size, you're not really creating an image.
NB, @size isn't mandatory for creating images. It isn't required
when creating qcow2 files with backing stores, as the size is
acquired from the backing file instead.
$ qemu-img create demo.raw 1g
Formatting 'demo.raw', fmt=raw size=1073741824
$ qemu-img create -o backing_file=demo.raw -o backing_fmt=raw -f qcow2 demo.qcow2
Formatting 'demo.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1073741824 backing_file=demo.raw backing_fmt=raw lazy_refcounts=off refcount_bits=16
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-02-28 11:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 3:36 [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment Hyman Huang
2024-02-21 6:43 ` Markus Armbruster
2024-02-21 7:08 ` Yong Huang
2024-02-21 8:26 ` Markus Armbruster
2024-02-21 8:49 ` Yong Huang
2024-02-28 6:43 ` Markus Armbruster
2024-02-28 10:17 ` Kevin Wolf
2024-02-28 10:23 ` Daniel P. Berrangé
2024-02-28 11:21 ` Kevin Wolf
2024-02-28 11:26 ` Daniel P. Berrangé
2024-02-28 11:30 ` Daniel P. Berrangé [this message]
2024-02-28 11:58 ` Kevin Wolf
2024-02-29 2:04 ` Yong Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd8ZOHJxhgrmbIWc@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).