From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CEE7C47DD9 for ; Wed, 28 Feb 2024 15:57:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfMHw-00005s-8Y; Wed, 28 Feb 2024 10:56:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfMHt-0008VS-Bw; Wed, 28 Feb 2024 10:56:05 -0500 Received: from mgamail.intel.com ([198.175.65.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfMHp-0004Jk-F7; Wed, 28 Feb 2024 10:56:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709135761; x=1740671761; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fNVWwNQheie9mBpZcQ8dmgIOe23qPbQo9xV4snxQxi4=; b=DFZ4FgXUkTfkQAwUZ4gi5/uETi8NRisLh1kGtTuz/zHfsCW+MvYdanOR Xop4yxQzkxs9d3SOzWeOapPNHAREgJJ2r9U0g04saaFgQAAo1cCW6r8S7 eVC2AskxjZMWMzV7jUuAJxoMtznPl6VV41SbXKcjr1QqnByyHONM2YoHn ej9d5X14ie/34FFck/ORM3/Mpem6FtdO3g0w1UR7SAkRqNtVZ9gqqXpFZ ECkPztI8jVPvreB2a/bz1EidfX3lTRdj34q64yrRbTYBIhTMdGZftSgz6 MRzMzd3C6UG8pFqEKr4Nf2et+0Toh2KMgJkZLMPvloD0/DBQdJWz9EMkR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="3464015" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="3464015" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 07:55:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="8040864" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by orviesa008.jf.intel.com with ESMTP; 28 Feb 2024 07:55:52 -0800 Date: Thu, 29 Feb 2024 00:09:34 +0800 From: Zhao Liu To: Markus Armbruster Cc: Jonathan Cameron , Fan Ni , Laurent Vivier , Alistair Francis , "Edgar E . Iglesias" , Peter Maydell , "Michael S . Tsirkin" , Marcel Apfelbaum , Alex Williamson , =?iso-8859-1?Q?C=E9dric?= Le Goater , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Paolo Bonzini , Michael Tokarev , qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-trivial@nongnu.org, Zhao Liu Subject: Re: [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config() Message-ID: References: <20240223085653.1255438-1-zhao1.liu@linux.intel.com> <20240223085653.1255438-2-zhao1.liu@linux.intel.com> <877cip3v24.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877cip3v24.fsf@pond.sub.org> Received-SPF: none client-ip=198.175.65.21; envelope-from=zhao1.liu@linux.intel.com; helo=mgamail.intel.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.102, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org > No need to quote the dereferences in full. > > But in cxl_fixed_memory_window_config(), @errp is dereferenced in 2 > places without ERRP_GUARD(). > > In these two places, we check "*errp", because neither function > > would do. > > Same for the other commit messages. > > Hardly worth a respin, though :) > I over-understood your reply. I'll pay attention to that in the follow up. Thanks, Zhao