From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E7D1C48BF8 for ; Mon, 19 Feb 2024 12:45:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc310-00063h-Tw; Mon, 19 Feb 2024 07:44:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc30z-00063O-6v for qemu-devel@nongnu.org; Mon, 19 Feb 2024 07:44:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc30x-0006hN-8u for qemu-devel@nongnu.org; Mon, 19 Feb 2024 07:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708346694; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=0aiChE9HTktmkdhdBbAto/Bv9YR1FTzeDtGFSngVeiA=; b=h43ZoPfnPfGWMuRd/OfGvSypxzynfE+L62v79DI/Bpim+sBkSZpHX2JuXOZL6CALgxJ8tq d3vS0fAhDcfb1B1aq+WPu8KsRrp8eHkMcDCDE3/U5QAgatLurgQGrPYFdMlxMB22w64joq NvDaQC/ela2E4lnQmeSOSkLjwm2lHhc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-YSqAubBYMJWs0LDeLz40wA-1; Mon, 19 Feb 2024 07:44:48 -0500 X-MC-Unique: YSqAubBYMJWs0LDeLz40wA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B8CAD3C025BE; Mon, 19 Feb 2024 12:44:47 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 515BE492BC6; Mon, 19 Feb 2024 12:44:44 +0000 (UTC) Date: Mon, 19 Feb 2024 12:44:42 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: Xiaoyao Li , Paolo Bonzini , David Hildenbrand , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Eric Blake , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang Subject: Re: [PATCH v4 11/66] i386: Introduce tdx-guest object Message-ID: References: <20240125032328.2522472-1-xiaoyao.li@intel.com> <20240125032328.2522472-12-xiaoyao.li@intel.com> <87a5nwfx9e.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87a5nwfx9e.fsf@pond.sub.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 19, 2024 at 01:34:37PM +0100, Markus Armbruster wrote: > Xiaoyao Li writes: > > > Introduce tdx-guest object which implements the interface of > > CONFIDENTIAL_GUEST_SUPPORT, and will be used to create TDX VMs (TDs) by > > > > qemu -machine ...,confidential-guest-support=tdx0 \ > > -object tdx-guest,id=tdx0 > > > > It has only one member 'attributes' with fixed value 0 and not > > configurable so far. > > Really? Can't see it. The 'attributes' referred to is an internal struct field, rather than a QAPI declared member. > > Suggest to add something like "Configuration properties will be added > later in this series." > > > Signed-off-by: Xiaoyao Li > > Acked-by: Gerd Hoffmann > > Acked-by: Markus Armbruster > > [...] > > > diff --git a/qapi/qom.json b/qapi/qom.json > > index 95516ba325e5..5b3c3146947f 100644 > > --- a/qapi/qom.json > > +++ b/qapi/qom.json > > @@ -895,6 +895,16 @@ > > 'reduced-phys-bits': 'uint32', > > '*kernel-hashes': 'bool' } } > > > > +## > > +# @TdxGuestProperties: > > +# > > +# Properties for tdx-guest objects. > > +# > > +# Since: 9.0 > > +## > > +{ 'struct': 'TdxGuestProperties', > > + 'data': { }} > > + > > ## > > # @ThreadContextProperties: > > # > > @@ -974,6 +984,7 @@ > > 'sev-guest', > > 'thread-context', > > 's390-pv-guest', > > + 'tdx-guest', > > 'throttle-group', > > 'tls-creds-anon', > > 'tls-creds-psk', > > @@ -1041,6 +1052,7 @@ > > 'secret_keyring': { 'type': 'SecretKeyringProperties', > > 'if': 'CONFIG_SECRET_KEYRING' }, > > 'sev-guest': 'SevGuestProperties', > > + 'tdx-guest': 'TdxGuestProperties', > > 'thread-context': 'ThreadContextProperties', > > 'throttle-group': 'ThrottleGroupProperties', > > 'tls-creds-anon': 'TlsCredsAnonProperties', > > [...] > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|