From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52323C48BC3 for ; Mon, 19 Feb 2024 12:55:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc3B1-0002F3-OD; Mon, 19 Feb 2024 07:55:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc3Av-0002Dv-UA for qemu-devel@nongnu.org; Mon, 19 Feb 2024 07:55:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc3At-0000BK-LF for qemu-devel@nongnu.org; Mon, 19 Feb 2024 07:55:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708347310; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=NwBOODxztdKsDqisIvyM9IhBF6k7LC35g6FHGcv17KM=; b=JZSZYG7WU/nM55VXctQHZ6PC3eKcLEKp+byQbOYLUsGpmo/jghQSYU/5KVyLS/Ak23tKfF IYWRYu/EK89GGsiOskrOpRiTSsqPfdkgb6IckH0llyRuFD1Exd/KvYcbzcqMPdiFucFkI+ 7DPwc71TZyCvEDYhzMZ/ph0EJHRtxgI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-GgTd6otXOJ-z2DtBEFjfsA-1; Mon, 19 Feb 2024 07:55:07 -0500 X-MC-Unique: GgTd6otXOJ-z2DtBEFjfsA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E508587B2A4; Mon, 19 Feb 2024 12:55:06 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CD6E2166B34; Mon, 19 Feb 2024 12:55:03 +0000 (UTC) Date: Mon, 19 Feb 2024 12:55:01 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: Xiaoyao Li , Paolo Bonzini , David Hildenbrand , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Eric Blake , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang Subject: Re: [PATCH v4 50/66] i386/tdx: handle TDG.VP.VMCALL Message-ID: References: <20240125032328.2522472-1-xiaoyao.li@intel.com> <20240125032328.2522472-51-xiaoyao.li@intel.com> <87zfvwehyz.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87zfvwehyz.fsf@pond.sub.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 19, 2024 at 01:50:12PM +0100, Markus Armbruster wrote: > Xiaoyao Li writes: > > > From: Isaku Yamahata > > > > Add property "quote-generation-socket" to tdx-guest, which is a property > > of type SocketAddress to specify Quote Generation Service(QGS). > > > > On request of GetQuote, it connects to the QGS socket, read request > > data from shared guest memory, send the request data to the QGS, > > and store the response into shared guest memory, at last notify > > TD guest by interrupt. > > > > command line example: > > qemu-system-x86_64 \ > > -object '{"qom-type":"tdx-guest","id":"tdx0","quote-generation-socket":{"type": "vsock", "cid":"1","port":"1234"}}' \ > > -machine confidential-guest-support=tdx0 > > > > Note, above example uses vsock type socket because the QGS we used > > implements the vsock socket. It can be other types, like UNIX socket, > > which depends on the implementation of QGS. > > > > To avoid no response from QGS server, setup a timer for the transaction. > > If timeout, make it an error and interrupt guest. Define the threshold of > > time to 30s at present, maybe change to other value if not appropriate. > > > > Signed-off-by: Isaku Yamahata > > Codeveloped-by: Chenyi Qiang > > Signed-off-by: Chenyi Qiang > > Codeveloped-by: Xiaoyao Li > > Signed-off-by: Xiaoyao Li > > --- > > Changes in v4: > > - merge next patch "i386/tdx: setup a timer for the qio channel"; > > > > Changes in v3: > > - rename property "quote-generation-service" to "quote-generation-socket"; > > - change the type of "quote-generation-socket" from str to > > SocketAddress; > > - squash next patch into this one; > > --- > > qapi/qom.json | 6 +- > > target/i386/kvm/meson.build | 2 +- > > target/i386/kvm/tdx-quote-generator.c | 170 ++++++++++++++++++++ > > target/i386/kvm/tdx-quote-generator.h | 95 +++++++++++ > > target/i386/kvm/tdx.c | 216 ++++++++++++++++++++++++++ > > target/i386/kvm/tdx.h | 6 + > > 6 files changed, 493 insertions(+), 2 deletions(-) > > create mode 100644 target/i386/kvm/tdx-quote-generator.c > > create mode 100644 target/i386/kvm/tdx-quote-generator.h > > > > diff --git a/qapi/qom.json b/qapi/qom.json > > index 15445f9e41fc..c60fb5710961 100644 > > --- a/qapi/qom.json > > +++ b/qapi/qom.json > > @@ -914,13 +914,17 @@ > > # e.g., specific to the workload rather than the run-time or OS. > > # base64 encoded SHA384 digest. > > # > > +# @quote-generation-socket: socket address for Quote Generation > > +# Service(QGS) > > Space between "Service" and "(QGS)", please. > > The description feels too terse. What is the "Quote Generation > Service", and why should I care? The "Quote Generation Service" is a daemon running on the host. The reference implementation is at https://github.com/intel/SGXDataCenterAttestationPrimitives/tree/master/QuoteGeneration/quote_wrapper/qgs If you don't provide this, then quests won't bet able to generate quotes needed for attestation. So although this is technically optional, in practice for a sane deployment, an admin should always provide this > > > +# > > # Since: 9.0 > > ## > > { 'struct': 'TdxGuestProperties', > > 'data': { '*sept-ve-disable': 'bool', > > '*mrconfigid': 'str', > > '*mrowner': 'str', > > - '*mrownerconfig': 'str' } } > > + '*mrownerconfig': 'str', > > + '*quote-generation-socket': 'SocketAddress' } } > > > > ## > > # @ThreadContextProperties: > > [...] > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|