From: Zhao Liu <zhao1.liu@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Igor Mammedov <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Bernhard Beschow <shentey@gmail.com>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH 4/5] hw/acpi/ich9_tco: Include missing 'migration/vmstate.h' header
Date: Tue, 20 Feb 2024 10:35:40 +0800 [thread overview]
Message-ID: <ZdQP/HaBa1MfRgIP@intel.com> (raw)
In-Reply-To: <20240219141412.71418-5-philmd@linaro.org>
On Mon, Feb 19, 2024 at 03:14:10PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 19 Feb 2024 15:14:10 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 4/5] hw/acpi/ich9_tco: Include missing
> 'migration/vmstate.h' header
> X-Mailer: git-send-email 2.41.0
>
> We need the VMStateDescription structure definition from
> "migration/vmstate.h" in order to declare vmstate_tco_io_sts.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/acpi/ich9_tco.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
>
> diff --git a/include/hw/acpi/ich9_tco.h b/include/hw/acpi/ich9_tco.h
> index c4393caee0..2562a7cf39 100644
> --- a/include/hw/acpi/ich9_tco.h
> +++ b/include/hw/acpi/ich9_tco.h
> @@ -11,6 +11,7 @@
> #define HW_ACPI_TCO_H
>
> #include "exec/memory.h"
> +#include "migration/vmstate.h"
>
> /* As per ICH9 spec, the internal timer has an error of ~0.6s on every tick */
> #define TCO_TICK_NSEC 600000000LL
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2024-02-20 2:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:14 [PATCH 0/5] hw/acpi: Include missing headers Philippe Mathieu-Daudé
2024-02-19 14:14 ` [PATCH 1/5] hw/acpi: Include missing 'qapi/qapi-types-acpi.h' generated header Philippe Mathieu-Daudé
2024-02-20 2:29 ` Zhao Liu
2024-02-19 14:14 ` [PATCH 2/5] hw/acpi/cpu: Use CPUState typedef Philippe Mathieu-Daudé
2024-02-19 14:14 ` [PATCH 3/5] hw/acpi/ich9: Include missing headers Philippe Mathieu-Daudé
2024-02-20 2:33 ` Zhao Liu
2024-02-20 7:09 ` Philippe Mathieu-Daudé
2024-02-19 14:14 ` [PATCH 4/5] hw/acpi/ich9_tco: Include missing 'migration/vmstate.h' header Philippe Mathieu-Daudé
2024-02-20 2:35 ` Zhao Liu [this message]
2024-02-19 14:14 ` [PATCH 5/5] hw/i386/q35: Include missing 'hw/acpi/acpi.h' header Philippe Mathieu-Daudé
2024-02-20 2:45 ` Zhao Liu
2024-02-20 7:10 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdQP/HaBa1MfRgIP@intel.com \
--to=zhao1.liu@intel.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).