qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Het Gala <het.gala@nutanix.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, berrange@redhat.com,
	farosas@suse.de
Subject: Re: [PATCH 2/3] qtest: migration: Introduce 'connect_channels' in MigrateCommon struct
Date: Tue, 20 Feb 2024 14:04:57 +0800	[thread overview]
Message-ID: <ZdRBCYIOiOV39i2x@x1n> (raw)
In-Reply-To: <20240216090624.75445-3-het.gala@nutanix.com>

On Fri, Feb 16, 2024 at 09:06:23AM +0000, Het Gala wrote:
> migration QAPIs can now work with either 'channels' or 'uri' as their
> argument.
> 
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
>  tests/qtest/migration-test.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index e7f2719dcf..0bc69b1943 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -704,6 +704,13 @@ typedef struct {
>       */
>      const char *connect_uri;
>  
> +    /*
> +     * Optional: list of migration stream channels, each connected
> +     * to a dst QEMU. It can be used instead of URI to carry out
> +     * the same task as listen_uri or connect_uri.
> +     */
> +    MigrationChannelList *connect_channels;
> +
>      /* Optional: callback to run at start to set migration parameters */
>      TestMigrateStartHook start_hook;
>      /* Optional: callback to run at finish to cleanup */

Please squash this patch into the follow up patch that uses it.  Thanks,

-- 
Peter Xu



  reply	other threads:[~2024-02-20  6:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16  9:06 [PATCH 0/3] qtest: migration: Add validation tests for 'channels' argument in migrate QAPIs Het Gala
2024-02-16  9:06 ` [PATCH 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument Het Gala
2024-02-20  6:03   ` Peter Xu
2024-02-20 18:14     ` Het Gala
2024-02-21  2:24       ` Peter Xu
2024-02-21  7:42         ` Het Gala
2024-02-16  9:06 ` [PATCH 2/3] qtest: migration: Introduce 'connect_channels' in MigrateCommon struct Het Gala
2024-02-20  6:04   ` Peter Xu [this message]
2024-02-20 18:43     ` Het Gala
2024-02-16  9:06 ` [PATCH 3/3] qtest: migration: Add negative validation test for 'uri' and 'channels' both set Het Gala
2024-02-20  6:27   ` Peter Xu
2024-02-20 18:51     ` Het Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdRBCYIOiOV39i2x@x1n \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=het.gala@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).