From: Peter Xu <peterx@redhat.com>
To: Hao Xiang <hao.xiang@bytedance.com>
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net,
farosas@suse.de, eblake@redhat.com, armbru@redhat.com,
thuth@redhat.com, lvivier@redhat.com, qemu-devel@nongnu.org,
jdenemar@redhat.com
Subject: Re: [PATCH v2 1/7] migration/multifd: Add new migration option zero-page-detection.
Date: Thu, 22 Feb 2024 18:36:34 +0800 [thread overview]
Message-ID: <Zdcjso7kUcZ5pL2o@x1n> (raw)
In-Reply-To: <20240216224002.1476890-2-hao.xiang@bytedance.com>
On Fri, Feb 16, 2024 at 10:39:56PM +0000, Hao Xiang wrote:
> @@ -1123,6 +1123,10 @@ static int save_zero_page(RAMState *rs, PageSearchStatus *pss,
> QEMUFile *file = pss->pss_channel;
> int len = 0;
>
> + if (migrate_zero_page_detection() != ZERO_PAGE_DETECTION_LEGACY) {
> + return 0;
> + }
Nitpick: use "== NONE" here seems clearer.
> +
> if (!buffer_is_zero(p, TARGET_PAGE_SIZE)) {
> return 0;
> }
--
Peter Xu
next prev parent reply other threads:[~2024-02-22 10:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 22:39 [PATCH v2 0/7] Introduce multifd zero page checking Hao Xiang
2024-02-16 22:39 ` [PATCH v2 1/7] migration/multifd: Add new migration option zero-page-detection Hao Xiang
2024-02-21 12:03 ` Markus Armbruster
2024-02-23 4:22 ` [External] " Hao Xiang
2024-02-21 13:58 ` Elena Ufimtseva
2024-02-23 4:37 ` [External] " Hao Xiang
2024-02-22 10:36 ` Peter Xu [this message]
2024-02-26 7:18 ` Wang, Lei
2024-02-26 19:45 ` [External] " Hao Xiang
2024-02-16 22:39 ` [PATCH v2 2/7] migration/multifd: Support for zero pages transmission in multifd format Hao Xiang
2024-02-21 15:37 ` Elena Ufimtseva
2024-02-23 4:18 ` [External] " Hao Xiang
2024-02-16 22:39 ` [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread Hao Xiang
2024-02-16 23:49 ` Richard Henderson
2024-02-23 4:38 ` [External] " Hao Xiang
2024-02-24 19:06 ` Hao Xiang
2024-02-21 12:04 ` Markus Armbruster
2024-02-21 16:00 ` Elena Ufimtseva
2024-02-23 4:59 ` [External] " Hao Xiang
2024-02-21 21:04 ` Fabiano Rosas
2024-02-23 2:20 ` Peter Xu
2024-02-23 5:15 ` [External] " Hao Xiang
2024-02-24 22:56 ` Hao Xiang
2024-02-26 1:30 ` Peter Xu
2024-02-23 5:18 ` Hao Xiang
2024-02-23 14:47 ` Fabiano Rosas
2024-02-16 22:39 ` [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads Hao Xiang
2024-02-21 16:11 ` Elena Ufimtseva
2024-02-23 5:24 ` [External] " Hao Xiang
2024-02-21 21:06 ` Fabiano Rosas
2024-02-23 2:33 ` Peter Xu
2024-02-23 6:02 ` [External] " Hao Xiang
2024-02-24 23:03 ` Hao Xiang
2024-02-26 1:43 ` Peter Xu
2024-02-23 5:47 ` Hao Xiang
2024-02-23 14:38 ` Fabiano Rosas
2024-02-16 22:40 ` [PATCH v2 5/7] migration/multifd: Add new migration test cases for legacy zero page checking Hao Xiang
2024-02-21 20:59 ` Fabiano Rosas
2024-02-23 4:20 ` [External] " Hao Xiang
2024-02-16 22:40 ` [PATCH v2 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface Hao Xiang
2024-02-21 12:07 ` Markus Armbruster
2024-02-16 22:40 ` [PATCH v2 7/7] Update maintainer contact for migration multifd zero page checking acceleration Hao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdcjso7kUcZ5pL2o@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=hao.xiang@bytedance.com \
--cc=jdenemar@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).