From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Yonggang Luo" <luoyonggang@gmail.com>
Subject: Re: [PATCH v2 3/3] .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction
Date: Thu, 22 Feb 2024 13:11:19 +0000 [thread overview]
Message-ID: <ZddH9yeH7-GkGtKz@redhat.com> (raw)
In-Reply-To: <20240222130920.362517-4-peter.maydell@linaro.org>
On Thu, Feb 22, 2024 at 01:09:20PM +0000, Peter Maydell wrote:
> Now we don't build msys2-32bit we don't need the abstraction out of the
> common msys2 handling from the 32-vs-64-bit specifics. Collapse it
> down into the msys2-64bit job definition.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v2:
> - drop now-unused MINGW_TARGET variable
> - document why we need to set MSYSTEM
> - restore comment text truncated in commit 11961d08fcbddf
> ---
> .gitlab-ci.d/windows.yml | 85 +++++++++++++++++++---------------------
> 1 file changed, 41 insertions(+), 44 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-02-22 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 13:09 [PATCH v2 0/3] Drop 32-bit Windows as a supported platform Peter Maydell
2024-02-22 13:09 ` [PATCH v2 1/3] docs: Document that 32-bit Windows is unsupported Peter Maydell
2024-02-22 13:09 ` [PATCH v2 2/3] .gitlab-ci.d: Drop cross-win32-system job Peter Maydell
2024-02-22 13:09 ` [PATCH v2 3/3] .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction Peter Maydell
2024-02-22 13:11 ` Daniel P. Berrangé [this message]
2024-02-22 13:12 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZddH9yeH7-GkGtKz@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).