From: Peter Xu <peterx@redhat.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cedric Le Goater <clg@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Marc-Andre Lureau <marcandre.lureau@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH V4 10/14] migration: stop vm for cpr
Date: Mon, 26 Feb 2024 10:08:57 +0800 [thread overview]
Message-ID: <ZdvyuazPp6Lrn5Mr@x1n> (raw)
In-Reply-To: <1708622920-68779-11-git-send-email-steven.sistare@oracle.com>
On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote:
> When migration for cpr is initiated, stop the vm and set state
> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the
> possibility of ram and device state being out of sync, and guarantees
> that a guest in the suspended state remains suspended, because qmp_cont
> rejects a cont command in the RUN_STATE_FINISH_MIGRATE state.
>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
cpr-reboot mode keeps changing behavior.
Could we declare it "experimental" until it's solid? Maybe a patch to
document this?
Normally IMHO we shouldn't merge a feature if it's not complete, however
cpr-reboot is so special that the mode itself is already merged in 8.2
before I started to merge patches, and it keeps changing things. I don't
know what else we can do here besides declaring it experimental and not
declare it a stable feature.
--
Peter Xu
next prev parent reply other threads:[~2024-02-26 2:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 17:28 [PATCH V4 00/14] allow cpr-reboot for vfio Steve Sistare
2024-02-22 17:28 ` [PATCH V4 01/14] notify: pass error to notifier with return Steve Sistare
2024-02-22 17:28 ` [PATCH V4 02/14] migration: remove error from notifier data Steve Sistare
2024-02-22 17:28 ` [PATCH V4 03/14] migration: convert to NotifierWithReturn Steve Sistare
2024-02-22 17:28 ` [PATCH V4 04/14] migration: MigrationEvent for notifiers Steve Sistare
2024-02-22 17:28 ` [PATCH V4 05/14] migration: remove postcopy_after_devices Steve Sistare
2024-02-22 17:28 ` [PATCH V4 06/14] migration: MigrationNotifyFunc Steve Sistare
2024-02-22 17:28 ` [PATCH V4 07/14] migration: per-mode notifiers Steve Sistare
2024-02-22 17:28 ` [PATCH V4 08/14] migration: refactor migrate_fd_connect failures Steve Sistare
2024-02-22 17:28 ` [PATCH V4 09/14] migration: notifier error checking Steve Sistare
2024-02-26 2:03 ` Peter Xu
2024-02-22 17:28 ` [PATCH V4 10/14] migration: stop vm for cpr Steve Sistare
2024-02-26 2:08 ` Peter Xu [this message]
2024-02-29 15:21 ` Steven Sistare
2024-03-01 1:28 ` Peter Xu
2024-03-01 10:41 ` Cédric Le Goater
2024-03-13 14:18 ` Steven Sistare
2024-03-13 21:22 ` Cédric Le Goater
2024-02-22 17:28 ` [PATCH V4 11/14] vfio: register container " Steve Sistare
2024-02-29 8:35 ` Cédric Le Goater
2024-02-29 13:40 ` Steven Sistare
2024-02-22 17:28 ` [PATCH V4 12/14] vfio: allow cpr-reboot migration if suspended Steve Sistare
2024-02-29 8:44 ` Cédric Le Goater
2024-02-22 17:28 ` [PATCH V4 13/14] migration: update cpr-reboot description Steve Sistare
2024-02-26 2:10 ` Peter Xu
2024-02-28 7:12 ` Markus Armbruster
2024-02-22 17:28 ` [PATCH V4 14/14] migration: options incompatible with cpr Steve Sistare
2024-02-26 2:10 ` Peter Xu
2024-02-28 7:21 ` Markus Armbruster
2024-02-28 13:23 ` Steven Sistare
2024-02-28 16:05 ` Markus Armbruster
2024-02-28 16:31 ` Steven Sistare
2024-02-29 5:31 ` Markus Armbruster
2024-02-29 5:40 ` Peter Xu
2024-02-29 14:59 ` Steven Sistare
2024-02-22 17:33 ` [PATCH V4 00/14] allow cpr-reboot for vfio Steven Sistare
2024-02-26 2:14 ` Peter Xu
2024-02-26 8:49 ` Cédric Le Goater
2024-02-26 9:01 ` Peter Xu
2024-02-26 20:21 ` Steven Sistare
2024-02-26 22:08 ` Steven Sistare
2024-02-27 4:07 ` Peter Xu
2024-03-08 16:52 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdvyuazPp6Lrn5Mr@x1n \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).