qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Frediano Ziglio <freddy77@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Laurent Vivier" <laurent@vivier.eu>,
	qemu-trivial@nongnu.org
Subject: Re: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
Date: Sat, 2 Mar 2024 15:06:56 +0800	[thread overview]
Message-ID: <ZeLQEEtbcPJpxenT@intel.com> (raw)
In-Reply-To: <CAHt6W4fiLh+bBOX1qwvm-1qJVG=j9SrT5rMJnEaMSWPjwwZr1g@mail.gmail.com>

On Fri, Mar 01, 2024 at 06:55:35PM +0000, Frediano Ziglio wrote:
> Date: Fri, 1 Mar 2024 18:55:35 +0000
> From: Frediano Ziglio <freddy77@gmail.com>
> Subject: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>  hw/vfio/pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> index 6e64a2654e..4bb7d7d257 100644
> --- a/hw/vfio/pci.h
> +++ b/hw/vfio/pci.h
> @@ -181,7 +181,7 @@ struct VFIOPCIDevice {
>      Notifier irqchip_change_notifier;
>  };
> 
> -/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
> +/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
> match hw */

It would be better to also change the comment style as:

/*
 * Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
 * match hw.
 */

Otherwise,

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

>  static inline bool vfio_pci_is(VFIOPCIDevice *vdev, uint32_t vendor,
> uint32_t device)
>  {
>      return (vendor == PCI_ANY_ID || vendor == vdev->vendor_id) &&
> -- 
> 2.34.1
> 


  reply	other threads:[~2024-03-02  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 18:55 [PATCH] Fix typo in comment (uin32_t -> uint32_t) Frediano Ziglio
2024-03-02  7:06 ` Zhao Liu [this message]
2024-03-04  6:04   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeLQEEtbcPJpxenT@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=freddy77@gmail.com \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).