From: Peter Xu <peterx@redhat.com>
To: Hao Xiang <hao.xiang@bytedance.com>
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net,
farosas@suse.de, eblake@redhat.com, armbru@redhat.com,
thuth@redhat.com, lvivier@redhat.com, jdenemar@redhat.com,
marcel.apfelbaum@gmail.com, philmd@linaro.org,
wangyanan55@huawei.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 4/7] migration/multifd: Enable multifd zero page checking by default.
Date: Mon, 4 Mar 2024 15:20:40 +0800 [thread overview]
Message-ID: <ZeV2SDWF2skToUoX@x1n> (raw)
In-Reply-To: <20240301022829.3390548-5-hao.xiang@bytedance.com>
On Fri, Mar 01, 2024 at 02:28:26AM +0000, Hao Xiang wrote:
> Set default "zero-page-detection" option to "multifd". Now zero page
> checking can be done in the multifd threads and this becomes the
> default configuration. We still provide backward compatibility
> where zero page checking is done from the migration main thread.
>
> Signed-off-by: Hao Xiang <hao.xiang@bytedance.com>
Either this patch can be squashed into patch 2, or you can move
hw_compat_8_2[] changes from patch 2 into this patch. The change itself
looks good.
--
Peter Xu
next prev parent reply other threads:[~2024-03-04 7:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 2:28 [PATCH v4 0/7] Introduce multifd zero page checking Hao Xiang
2024-03-01 2:28 ` [PATCH v4 1/7] migration/multifd: Add new migration option zero-page-detection Hao Xiang
2024-03-01 7:24 ` Markus Armbruster
2024-03-04 7:01 ` Peter Xu
2024-03-01 2:28 ` [PATCH v4 2/7] migration/multifd: Implement zero page transmission on the multifd thread Hao Xiang
2024-03-01 7:28 ` Markus Armbruster
2024-03-01 22:49 ` [External] " Hao Xiang
2024-03-04 7:16 ` Peter Xu
2024-03-04 13:17 ` Fabiano Rosas
2024-03-04 14:31 ` Fabiano Rosas
2024-03-04 14:39 ` Fabiano Rosas
2024-03-04 18:24 ` Fabiano Rosas
[not found] ` <CAAYibXiLLztnPnKkGZKgXpD8HfSsFqdmhUGcETpzQDUoURRNwg@mail.gmail.com>
2024-03-09 8:08 ` hao.xiang
[not found] ` <CAAYibXi0xjpwayO1u8P4skjpeOuUteyuRmrhFHmjFwoRF2JWJg@mail.gmail.com>
2024-03-09 2:37 ` [External] " hao.xiang
2024-03-01 2:28 ` [PATCH v4 3/7] migration/multifd: Implement ram_save_target_page_multifd to handle multifd version of MigrationOps::ram_save_target_page Hao Xiang
2024-03-04 7:46 ` Peter Xu
[not found] ` <CAAYibXhCzozRhHxp2Dk3L9BMhFhZtqyvgbwkj+8ZGMCHURZGug@mail.gmail.com>
2024-03-09 2:06 ` hao.xiang
2024-03-11 13:20 ` Peter Xu
2024-03-11 18:02 ` hao.xiang
2024-03-01 2:28 ` [PATCH v4 4/7] migration/multifd: Enable multifd zero page checking by default Hao Xiang
2024-03-04 7:20 ` Peter Xu [this message]
2024-03-01 2:28 ` [PATCH v4 5/7] migration/multifd: Add new migration test cases for legacy zero page checking Hao Xiang
2024-03-04 7:23 ` Peter Xu
2024-03-01 2:28 ` [PATCH v4 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface Hao Xiang
2024-03-01 7:40 ` Markus Armbruster
[not found] ` <CAAYibXjyMT5YJqOcDheDUB1qzi+JjFhAcv3L57zM9pCFMGbYbw@mail.gmail.com>
2024-03-09 6:56 ` [External] " hao.xiang
2024-03-01 2:28 ` [PATCH v4 7/7] Update maintainer contact for migration multifd zero page checking acceleration Hao Xiang
2024-03-04 7:34 ` Peter Xu
[not found] ` <CAAYibXjoji3GY7TW_USFsuT3YyVnv_kGFXpvBgK_kf9i1S1VSw@mail.gmail.com>
2024-03-09 8:13 ` hao.xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeV2SDWF2skToUoX@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=hao.xiang@bytedance.com \
--cc=jdenemar@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).