From: Peter Xu <peterx@redhat.com>
To: Hao Xiang <hao.xiang@bytedance.com>
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net,
farosas@suse.de, eblake@redhat.com, armbru@redhat.com,
thuth@redhat.com, lvivier@redhat.com, jdenemar@redhat.com,
marcel.apfelbaum@gmail.com, philmd@linaro.org,
wangyanan55@huawei.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 7/7] Update maintainer contact for migration multifd zero page checking acceleration.
Date: Mon, 4 Mar 2024 15:34:27 +0800 [thread overview]
Message-ID: <ZeV5g8nuP2NpYQ5v@x1n> (raw)
In-Reply-To: <20240301022829.3390548-8-hao.xiang@bytedance.com>
On Fri, Mar 01, 2024 at 02:28:29AM +0000, Hao Xiang wrote:
> Add myself to maintain multifd zero page checking acceleration function.
>
> Signed-off-by: Hao Xiang <hao.xiang@bytedance.com>
> ---
> MAINTAINERS | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 65dfdc9677..b547918e4d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3414,6 +3414,11 @@ F: tests/migration/
> F: util/userfaultfd.c
> X: migration/rdma*
>
> +Migration multifd zero page checking acceleration
> +M: Hao Xiang <hao.xiang@bytedance.com>
> +S: Maintained
> +F: migration/multifd-zero-page.c
> +
Firstly appreciate a lot for volunteering!
My fault to not have made it clear. This file alone so far will need to be
closely related to the multifd core, so whoever maintains migration should
look after this. It's also slightly weird to have a separate entry for a
file that is tens of LOC if it's already covered by another upper entry.
What I worry is about vendor/library specific parts that will be harder to
maintain, and migration maintainers (no matter who does the job in the
future) may not always cover those areas. So I was expecting we could have
volunteers covering e.g. QAT / DSA / IAA accelerators. Since all these
accelerators will all be part of Intel's new chips, there's also one way
that we have "Intel accelerators" section to cover vendor specific codes
and then cover all those areas no matter it's zero detect accelerator or HW
compressors.
I'd suggest we discuss this with Intel people to check out a solid plan
later when we start to merge HW/LIB specific codes. For now I suggest we
can drop this patch and stick with the feature implementation, to see
whether it can catch the train for 9.0. IMHO this is a good feature even
without HW accelerators (and I think it's close to ready), so I hope it can
still make it.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2024-03-04 7:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 2:28 [PATCH v4 0/7] Introduce multifd zero page checking Hao Xiang
2024-03-01 2:28 ` [PATCH v4 1/7] migration/multifd: Add new migration option zero-page-detection Hao Xiang
2024-03-01 7:24 ` Markus Armbruster
2024-03-04 7:01 ` Peter Xu
2024-03-01 2:28 ` [PATCH v4 2/7] migration/multifd: Implement zero page transmission on the multifd thread Hao Xiang
2024-03-01 7:28 ` Markus Armbruster
2024-03-01 22:49 ` [External] " Hao Xiang
2024-03-04 7:16 ` Peter Xu
2024-03-04 13:17 ` Fabiano Rosas
2024-03-04 14:31 ` Fabiano Rosas
2024-03-04 14:39 ` Fabiano Rosas
2024-03-04 18:24 ` Fabiano Rosas
[not found] ` <CAAYibXiLLztnPnKkGZKgXpD8HfSsFqdmhUGcETpzQDUoURRNwg@mail.gmail.com>
2024-03-09 8:08 ` hao.xiang
[not found] ` <CAAYibXi0xjpwayO1u8P4skjpeOuUteyuRmrhFHmjFwoRF2JWJg@mail.gmail.com>
2024-03-09 2:37 ` [External] " hao.xiang
2024-03-01 2:28 ` [PATCH v4 3/7] migration/multifd: Implement ram_save_target_page_multifd to handle multifd version of MigrationOps::ram_save_target_page Hao Xiang
2024-03-04 7:46 ` Peter Xu
[not found] ` <CAAYibXhCzozRhHxp2Dk3L9BMhFhZtqyvgbwkj+8ZGMCHURZGug@mail.gmail.com>
2024-03-09 2:06 ` hao.xiang
2024-03-11 13:20 ` Peter Xu
2024-03-11 18:02 ` hao.xiang
2024-03-01 2:28 ` [PATCH v4 4/7] migration/multifd: Enable multifd zero page checking by default Hao Xiang
2024-03-04 7:20 ` Peter Xu
2024-03-01 2:28 ` [PATCH v4 5/7] migration/multifd: Add new migration test cases for legacy zero page checking Hao Xiang
2024-03-04 7:23 ` Peter Xu
2024-03-01 2:28 ` [PATCH v4 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface Hao Xiang
2024-03-01 7:40 ` Markus Armbruster
[not found] ` <CAAYibXjyMT5YJqOcDheDUB1qzi+JjFhAcv3L57zM9pCFMGbYbw@mail.gmail.com>
2024-03-09 6:56 ` [External] " hao.xiang
2024-03-01 2:28 ` [PATCH v4 7/7] Update maintainer contact for migration multifd zero page checking acceleration Hao Xiang
2024-03-04 7:34 ` Peter Xu [this message]
[not found] ` <CAAYibXjoji3GY7TW_USFsuT3YyVnv_kGFXpvBgK_kf9i1S1VSw@mail.gmail.com>
2024-03-09 8:13 ` hao.xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeV5g8nuP2NpYQ5v@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=hao.xiang@bytedance.com \
--cc=jdenemar@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).