From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B77D4C48BF6 for ; Mon, 4 Mar 2024 08:07:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rh3Lk-0001FO-Hz; Mon, 04 Mar 2024 03:07:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh3LQ-0001A4-T6 for qemu-devel@nongnu.org; Mon, 04 Mar 2024 03:06:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh3LK-0007v2-Hj for qemu-devel@nongnu.org; Mon, 04 Mar 2024 03:06:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709539591; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W1DIwgkq7TCFSzb4dD94iRS+S5ezKsP4dTkDD14stPI=; b=B1P/WIHNOmovykxHV9/tOBOQ6ELLB8UW8q5lpyBLnEafErRu9u/h0AEo/hfpDjzZZk9bsM y4Jps3Z9ArkFu5GlD7OLd+It/6EpKom/9Fp043qye+PBOl4hwizsXn56Z48rzoxdqneYdc 24B/4UHrwwGz+lfY6Zl7zFkPB7qSKBg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-BXBq-16TPMyfXMKpLnudHA-1; Mon, 04 Mar 2024 03:06:28 -0500 X-MC-Unique: BXBq-16TPMyfXMKpLnudHA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD7E71C06901; Mon, 4 Mar 2024 08:06:27 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77FD82022AAC; Mon, 4 Mar 2024 08:06:27 +0000 (UTC) Date: Mon, 4 Mar 2024 08:06:25 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Chun Feng Wu Cc: "qemu-devel@nongnu.org" Subject: Re: Does "-object" support structured options now? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.589, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Mar 04, 2024 at 06:43:19AM +0000, Chun Feng Wu wrote: > Hi, > > I noticed that throttle-group can be created with “-object”, however, per qemu doc(https://github.com/qemu/qemu/blob/master/docs/throttle.txt), “-object” doesn’t support structured options at that moment: > > “ > A throttle-group can also be created with the -object command line > option but at the moment there is no way to pass a 'limits' parameter > that contains a ThrottleLimits structure. The solution is to set the > individual values directly, like in this example: > > -object throttle-group,id=group0,x-iops-total=1000,x-bps-write=2097152 > > Note however that this is not a stable API (hence the 'x-' prefixes) and > will disappear when -object gains support for structured options and > enables use of 'limits'. > “ > > Does anybody know if the latest qemu code still lacks of such > support(structured options for -object)? If so, is there any > plan to support it(instead of non-stable API)? -object supports JSON syntax these days so any QAPI structure can be expressed no matter how complex. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|