qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] make-release: switch to .xz format by default
@ 2024-03-04 18:51 Michael Tokarev
  2024-03-04 21:06 ` Daniel P. Berrangé
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Michael Tokarev @ 2024-03-04 18:51 UTC (permalink / raw)
  To: qemu-devel; +Cc: Michael Roth, Michael Tokarev

For a long time, we provide two compression formats in the
download area, .bz2 and .xz.  There's absolutely no reason
to provide two in parallel, .xz compresses better, and all
the links we use points to .xz.  Downstream distributions
mostly use .xz too.

For the release maintenance providing two formats is definitely
extra burden too.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 scripts/make-release | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/make-release b/scripts/make-release
index 9c570b87f4..6e0433de24 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -47,5 +47,5 @@ meson subprojects download $SUBPROJECTS
         CryptoPkg/Library/OpensslLib/openssl \
         MdeModulePkg/Library/BrotliCustomDecompressLib/brotli)
 popd
-tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination}
+tar --exclude=.git -cJf ${destination}.tar.xz ${destination}
 rm -rf ${destination}
-- 
2.39.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] make-release: switch to .xz format by default
  2024-03-04 18:51 [PATCH] make-release: switch to .xz format by default Michael Tokarev
@ 2024-03-04 21:06 ` Daniel P. Berrangé
  2024-03-05  9:50 ` Peter Maydell
  2024-03-05 12:22 ` Stefan Hajnoczi
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2024-03-04 21:06 UTC (permalink / raw)
  To: Michael Tokarev; +Cc: qemu-devel, Michael Roth

On Mon, Mar 04, 2024 at 09:51:49PM +0300, Michael Tokarev wrote:
> For a long time, we provide two compression formats in the
> download area, .bz2 and .xz.  There's absolutely no reason
> to provide two in parallel, .xz compresses better, and all
> the links we use points to .xz.  Downstream distributions
> mostly use .xz too.
> 
> For the release maintenance providing two formats is definitely
> extra burden too.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] make-release: switch to .xz format by default
  2024-03-04 18:51 [PATCH] make-release: switch to .xz format by default Michael Tokarev
  2024-03-04 21:06 ` Daniel P. Berrangé
@ 2024-03-05  9:50 ` Peter Maydell
  2024-03-05 12:21   ` Stefan Hajnoczi
  2024-03-05 12:22 ` Stefan Hajnoczi
  2 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2024-03-05  9:50 UTC (permalink / raw)
  To: Michael Tokarev; +Cc: qemu-devel, Michael Roth, Paolo Bonzini, Stefan Hajnoczi

On Mon, 4 Mar 2024 at 18:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> For a long time, we provide two compression formats in the
> download area, .bz2 and .xz.  There's absolutely no reason
> to provide two in parallel, .xz compresses better, and all
> the links we use points to .xz.  Downstream distributions
> mostly use .xz too.

Seems reasonable. Out of curiosity, do we have the
download stats on how many .xz vs .bz2 downloads we get?
Stefan or Paolo, do you have the webserver info?
(Probably not worth bothering if it's a big pain to
get the data.)

thanks
-- PMM


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] make-release: switch to .xz format by default
  2024-03-05  9:50 ` Peter Maydell
@ 2024-03-05 12:21   ` Stefan Hajnoczi
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2024-03-05 12:21 UTC (permalink / raw)
  To: Peter Maydell
  Cc: Michael Tokarev, qemu-devel, Michael Roth, Paolo Bonzini,
	Stefan Hajnoczi

On Tue, 5 Mar 2024 at 04:52, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 4 Mar 2024 at 18:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
> >
> > For a long time, we provide two compression formats in the
> > download area, .bz2 and .xz.  There's absolutely no reason
> > to provide two in parallel, .xz compresses better, and all
> > the links we use points to .xz.  Downstream distributions
> > mostly use .xz too.
>
> Seems reasonable. Out of curiosity, do we have the
> download stats on how many .xz vs .bz2 downloads we get?
> Stefan or Paolo, do you have the webserver info?
> (Probably not worth bothering if it's a big pain to
> get the data.)

I don't have access to the CDN stats. Maybe Paolo does.

Stefan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] make-release: switch to .xz format by default
  2024-03-04 18:51 [PATCH] make-release: switch to .xz format by default Michael Tokarev
  2024-03-04 21:06 ` Daniel P. Berrangé
  2024-03-05  9:50 ` Peter Maydell
@ 2024-03-05 12:22 ` Stefan Hajnoczi
  2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2024-03-05 12:22 UTC (permalink / raw)
  To: Michael Tokarev; +Cc: qemu-devel, Michael Roth

On Mon, 4 Mar 2024 at 13:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> For a long time, we provide two compression formats in the
> download area, .bz2 and .xz.  There's absolutely no reason
> to provide two in parallel, .xz compresses better, and all
> the links we use points to .xz.  Downstream distributions
> mostly use .xz too.
>
> For the release maintenance providing two formats is definitely
> extra burden too.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

> diff --git a/scripts/make-release b/scripts/make-release
> index 9c570b87f4..6e0433de24 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -47,5 +47,5 @@ meson subprojects download $SUBPROJECTS
>          CryptoPkg/Library/OpensslLib/openssl \
>          MdeModulePkg/Library/BrotliCustomDecompressLib/brotli)
>  popd
> -tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination}
> +tar --exclude=.git -cJf ${destination}.tar.xz ${destination}
>  rm -rf ${destination}
> --
> 2.39.2
>
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-05 12:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 18:51 [PATCH] make-release: switch to .xz format by default Michael Tokarev
2024-03-04 21:06 ` Daniel P. Berrangé
2024-03-05  9:50 ` Peter Maydell
2024-03-05 12:21   ` Stefan Hajnoczi
2024-03-05 12:22 ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).