qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Kim, Dongwon" <dongwon.kim@intel.com>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible
Date: Thu, 7 Mar 2024 09:46:11 +0000	[thread overview]
Message-ID: <ZemM45aJdtzx9LH2@redhat.com> (raw)
In-Reply-To: <PH8PR11MB6879AF46B1B0A31E68D146F9FA432@PH8PR11MB6879.namprd11.prod.outlook.com>

On Thu, Feb 01, 2024 at 06:48:58PM +0000, Kim, Dongwon wrote:
> Hi Marc-André,
> 
> Thanks for your feedback. Yes, you are right, rendering doesn't stop on Ubuntu system
> as it has preview even after the window is minimized. But this is not always the case.
> Some simple windows managers don't have this preview (thumbnail)
> feature and this visible flag is not toggled. And the rendering stops right away there
> when the window is minimized.

This makes me pretty uncomfortable. This is proposing changing QEMU
behaviour to workaround a problem whose behaviour varies based on
what 3rd party software QEMU is running on

What you say "window managers" are you referring to a traditional
X11 based host display only, or does the problem also exist on
modern Wayland host display ?

If the problem is confined to X11, that would steer towards saying
we shouldn't try to workaround it given that X11 is very much
obsolete at this point.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2024-03-07  9:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 23:48 [PATCH 0/3] ui/gtk: introducing vc->visible dongwon.kim
2024-01-30 23:48 ` [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible dongwon.kim
2024-01-31  7:08   ` Marc-André Lureau
2024-01-31 18:56     ` Kim, Dongwon
2024-02-01  6:42       ` Marc-André Lureau
2024-02-01 18:48         ` Kim, Dongwon
2024-03-07  9:46           ` Daniel P. Berrangé [this message]
2024-03-07 17:53             ` Kim, Dongwon
2024-03-07 18:01               ` Daniel P. Berrangé
2024-03-07 19:50                 ` Kim, Dongwon
2024-03-07  9:40   ` Daniel P. Berrangé
2024-03-07 17:34     ` Kim, Dongwon
2024-01-30 23:48 ` [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible dongwon.kim
2024-01-31  7:12   ` Marc-André Lureau
2024-01-31 19:10     ` Kim, Dongwon
2024-03-07  9:47     ` Daniel P. Berrangé
2024-01-30 23:48 ` [PATCH 3/3] ui/gtk: reset visible flag when window is minimized dongwon.kim
2024-03-01  0:05 ` [PATCH 0/3] ui/gtk: introducing vc->visible Kim, Dongwon
2024-03-05 12:18   ` Marc-André Lureau
2024-03-07  9:49     ` Daniel P. Berrangé
2024-03-08  0:56     ` Kim, Dongwon
2024-03-08  7:43       ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZemM45aJdtzx9LH2@redhat.com \
    --to=berrange@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).