From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: dongwon.kim@intel.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible
Date: Thu, 7 Mar 2024 09:47:59 +0000 [thread overview]
Message-ID: <ZemNT-651Kl5S3uY@redhat.com> (raw)
In-Reply-To: <CAJ+F1CKH6oWkvN44de_FT0hG5vKd8pKapn62OM+DfmQggnDcHg@mail.gmail.com>
On Wed, Jan 31, 2024 at 11:12:57AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jan 31, 2024 at 3:50 AM <dongwon.kim@intel.com> wrote:
> >
> > From: Dongwon Kim <dongwon.kim@intel.com>
> >
> > UI size is set to 0 when the VC is invisible, which will prevent
> > the further scanout update by notifying the guest that the display
> > is not in active state. Then it is restored to the original size
> > whenever the VC becomes visible again.
>
> This can have unwanted results on multi monitor setups, such as moving
> windows or icons around on different monitors.
>
> Switching tabs or minimizing the display window shouldn't cause a
> guest display reconfiguration.
I agree, changing the size of displays as a side-effect of
something that isn't a guest owner initiated resize operation
is asking for trouble.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-03-07 9:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 23:48 [PATCH 0/3] ui/gtk: introducing vc->visible dongwon.kim
2024-01-30 23:48 ` [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible dongwon.kim
2024-01-31 7:08 ` Marc-André Lureau
2024-01-31 18:56 ` Kim, Dongwon
2024-02-01 6:42 ` Marc-André Lureau
2024-02-01 18:48 ` Kim, Dongwon
2024-03-07 9:46 ` Daniel P. Berrangé
2024-03-07 17:53 ` Kim, Dongwon
2024-03-07 18:01 ` Daniel P. Berrangé
2024-03-07 19:50 ` Kim, Dongwon
2024-03-07 9:40 ` Daniel P. Berrangé
2024-03-07 17:34 ` Kim, Dongwon
2024-01-30 23:48 ` [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible dongwon.kim
2024-01-31 7:12 ` Marc-André Lureau
2024-01-31 19:10 ` Kim, Dongwon
2024-03-07 9:47 ` Daniel P. Berrangé [this message]
2024-01-30 23:48 ` [PATCH 3/3] ui/gtk: reset visible flag when window is minimized dongwon.kim
2024-03-01 0:05 ` [PATCH 0/3] ui/gtk: introducing vc->visible Kim, Dongwon
2024-03-05 12:18 ` Marc-André Lureau
2024-03-07 9:49 ` Daniel P. Berrangé
2024-03-08 0:56 ` Kim, Dongwon
2024-03-08 7:43 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZemNT-651Kl5S3uY@redhat.com \
--to=berrange@redhat.com \
--cc=dongwon.kim@intel.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).