[PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

[PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

[Peter Maydell]

On our gcov CI job, the bufferiszero and crypto-tlscredsx509
tests time out occasionally, making the job flaky. Double the
timeout on these two tests.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
cc stable just because it probably helps CI reliability there too
---
 tests/unit/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/unit/meson.build b/tests/unit/meson.build
index cae925c1325..30db3c418fa 100644
--- a/tests/unit/meson.build
+++ b/tests/unit/meson.build
@@ -173,8 +173,9 @@ test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
 
 slow_tests = {
   'test-aio-multithread' : 120,
+  'test-bufferiszero': 60,
   'test-crypto-block' : 300,
-  'test-crypto-tlscredsx509': 45,
+  'test-crypto-tlscredsx509': 90,
   'test-crypto-tlssession': 45,
   'test-replication': 60,
 }
-- 
2.34.1

Re: [PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

[Daniel P. Berrangé]

On Tue, Mar 12, 2024 at 11:08:15AM +0000, Peter Maydell wrote:
> On our gcov CI job, the bufferiszero and crypto-tlscredsx509
> tests time out occasionally, making the job flaky. Double the
> timeout on these two tests.
> 
> Cc: qemu-stable@nongnu.org
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> cc stable just because it probably helps CI reliability there too
> ---
>  tests/unit/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/unit/meson.build b/tests/unit/meson.build
> index cae925c1325..30db3c418fa 100644
> --- a/tests/unit/meson.build
> +++ b/tests/unit/meson.build
> @@ -173,8 +173,9 @@ test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
>  
>  slow_tests = {
>    'test-aio-multithread' : 120,
> +  'test-bufferiszero': 60,
>    'test-crypto-block' : 300,
> -  'test-crypto-tlscredsx509': 45,
> +  'test-crypto-tlscredsx509': 90,
>    'test-crypto-tlssession': 45,

I'd probably suggest bumping this to 90 too, as it is a similar order
to CPU burn complexity to the other tls test - both of them create
a huge number of certs for testing many scenarios.

Either way,

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

[Peter Maydell]

On Tue, 12 Mar 2024 at 11:18, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Mar 12, 2024 at 11:08:15AM +0000, Peter Maydell wrote:
> > On our gcov CI job, the bufferiszero and crypto-tlscredsx509
> > tests time out occasionally, making the job flaky. Double the
> > timeout on these two tests.
> >
> > Cc: qemu-stable@nongnu.org
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > cc stable just because it probably helps CI reliability there too
> > ---
> >  tests/unit/meson.build | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/unit/meson.build b/tests/unit/meson.build
> > index cae925c1325..30db3c418fa 100644
> > --- a/tests/unit/meson.build
> > +++ b/tests/unit/meson.build
> > @@ -173,8 +173,9 @@ test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
> >
> >  slow_tests = {
> >    'test-aio-multithread' : 120,
> > +  'test-bufferiszero': 60,
> >    'test-crypto-block' : 300,
> > -  'test-crypto-tlscredsx509': 45,
> > +  'test-crypto-tlscredsx509': 90,
> >    'test-crypto-tlssession': 45,
>
> I'd probably suggest bumping this to 90 too, as it is a similar order
> to CPU burn complexity to the other tls test - both of them create
> a huge number of certs for testing many scenarios.
>
> Either way,
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks; I'm going to apply this directly with the tlssession
timeout also raised to 90.

-- PMM