From: Zhao Liu <zhao1.liu@intel.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
qemu-block@nongnu.org, philmd@linaro.org
Subject: Re: [PATCH 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition
Date: Tue, 12 Mar 2024 23:08:50 +0800 [thread overview]
Message-ID: <ZfBwAlgPMIhZKyiB@intel.com> (raw)
In-Reply-To: <20240312141343.3168265-4-armbru@redhat.com>
On Tue, Mar 12, 2024 at 03:13:36PM +0100, Markus Armbruster wrote:
> Date: Tue, 12 Mar 2024 15:13:36 +0100
> From: Markus Armbruster <armbru@redhat.com>
> Subject: [PATCH 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM
> definition
>
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
> * These macros will go away, please don't use
> * in new code, and do not add new ones!
> */
>
> Mechanical transformation using sed, and manual cleanup.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qapi/qmp/qerror.h | 3 ---
> block/snapshot.c | 7 ++++---
> blockdev.c | 2 +-
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2024-03-12 14:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 14:13 [PATCH 00/10] Reduce usage of QERR_ macros further Markus Armbruster
2024-03-12 14:13 ` [PATCH 01/10] error: Drop superfluous #include "qapi/qmp/qerror.h" Markus Armbruster
2024-03-12 15:05 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 02/10] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition Markus Armbruster
2024-03-12 15:07 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition Markus Armbruster
2024-03-12 15:08 ` Zhao Liu [this message]
2024-03-12 14:13 ` [PATCH 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition Markus Armbruster
2024-03-12 15:11 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER definition Markus Armbruster
2024-03-12 15:14 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value) Markus Armbruster
2024-03-12 15:18 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition Markus Armbruster
2024-03-12 15:21 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter Markus Armbruster
2024-03-12 15:26 ` Zhao Liu
2024-03-12 17:51 ` Philippe Mathieu-Daudé
2024-03-18 8:58 ` Markus Armbruster
2024-03-18 10:14 ` Philippe Mathieu-Daudé
2024-03-12 14:13 ` [PATCH 09/10] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition Markus Armbruster
2024-03-12 15:21 ` Zhao Liu
2024-03-12 14:13 ` [PATCH 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition Markus Armbruster
2024-03-12 15:22 ` Zhao Liu
2024-03-18 10:49 ` [PATCH 00/10] Reduce usage of QERR_ macros further Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfBwAlgPMIhZKyiB@intel.com \
--to=zhao1.liu@intel.com \
--cc=armbru@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).