From: Zhao Liu <zhao1.liu@intel.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com,
eduardo@habkost.net, chao.p.peng@intel.com
Subject: Re: [PATCH v2 3/3] qom/object_interfaces: Remove local_err in user_creatable_add_type
Date: Mon, 18 Mar 2024 16:57:37 +0800 [thread overview]
Message-ID: <ZfgCAfLCgxvzlvno@intel.com> (raw)
In-Reply-To: <20240318033211.459006-4-zhenzhong.duan@intel.com>
On Mon, Mar 18, 2024 at 11:32:10AM +0800, Zhenzhong Duan wrote:
> Date: Mon, 18 Mar 2024 11:32:10 +0800
> From: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Subject: [PATCH v2 3/3] qom/object_interfaces: Remove local_err in
> user_creatable_add_type
> X-Mailer: git-send-email 2.34.1
>
> In user_creatable_add_type, there is mixed usage of ERRP_GUARD and
> local_err. This makes error_abort not taking effect in those callee
> functions with &local_err passed.
>
> Now that we already use ERRP_GUARD, remove local_err and pass errp.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
> qom/object_interfaces.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2024-03-18 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 3:32 [PATCH v2 0/3] Simplify user_creatable_add_type error path Zhenzhong Duan
2024-03-18 3:32 ` [PATCH v2 1/3] qom/object_interfaces: Remove unnecessary local error check Zhenzhong Duan
2024-03-18 3:32 ` [PATCH v2 2/3] qom/object_interfaces: Make object_set_properties_from_qdict return bool Zhenzhong Duan
2024-03-18 8:56 ` Zhao Liu
2024-03-18 3:32 ` [PATCH v2 3/3] qom/object_interfaces: Remove local_err in user_creatable_add_type Zhenzhong Duan
2024-03-18 8:57 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfgCAfLCgxvzlvno@intel.com \
--to=zhao1.liu@intel.com \
--cc=berrange@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).