From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com, kkostiuk@redhat.com,
marcandre.lureau@redhat.com, philmd@linaro.org,
den@virtuozzo.com
Subject: Re: [PATCH v3 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper
Date: Tue, 19 Mar 2024 18:00:59 +0000 [thread overview]
Message-ID: <ZfnS2_p5g25oY4K7@redhat.com> (raw)
In-Reply-To: <20240315122946.39168-8-andrey.drobyshev@virtuozzo.com>
On Fri, Mar 15, 2024 at 02:29:46PM +0200, Andrey Drobyshev wrote:
> There's no need to check for the existence of the "chpasswd", "pw"
> executables, as the exec() call will do that for us.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> ---
> qga/commands-posix.c | 96 ++++++--------------------------------------
> 1 file changed, 13 insertions(+), 83 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2024-03-19 18:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 12:29 [PATCH v3 0/7] qga/commands-posix: replace code duplicating commands with a helper Andrey Drobyshev
2024-03-15 12:29 ` [PATCH v3 1/7] qga: guest-get-fsinfo: add optional 'total-bytes-root' field Andrey Drobyshev
2024-03-15 13:44 ` Markus Armbruster
2024-03-15 14:27 ` Andrey Drobyshev
2024-03-19 17:37 ` Daniel P. Berrangé
2024-03-20 15:45 ` Andrey Drobyshev
2024-03-15 12:29 ` [PATCH v3 2/7] qga: introduce ga_run_command() helper for guest cmd execution Andrey Drobyshev
2024-03-19 17:55 ` Daniel P. Berrangé
2024-03-15 12:29 ` [PATCH v3 3/7] qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper Andrey Drobyshev
2024-03-19 17:57 ` Daniel P. Berrangé
2024-03-15 12:29 ` [PATCH v3 4/7] qga/commands-posix: qmp_guest_set_time: " Andrey Drobyshev
2024-03-19 17:58 ` Daniel P. Berrangé
2024-03-15 12:29 ` [PATCH v3 5/7] qga/commands-posix: execute_fsfreeze_hook: " Andrey Drobyshev
2024-03-19 18:00 ` Daniel P. Berrangé
2024-03-15 12:29 ` [PATCH v3 6/7] qga/commands-posix: don't do fork()/exec() when suspending via sysfs Andrey Drobyshev
2024-03-19 18:02 ` Daniel P. Berrangé
2024-03-20 15:46 ` Andrey Drobyshev
2024-03-15 12:29 ` [PATCH v3 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper Andrey Drobyshev
2024-03-19 18:00 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfnS2_p5g25oY4K7@redhat.com \
--to=berrange@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).