* [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()
@ 2024-03-19 2:16 Shiyang Ruan via
2024-03-19 12:54 ` [PATCH-for-9.0] " Philippe Mathieu-Daudé
2024-03-26 9:58 ` [PATCH] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Shiyang Ruan via @ 2024-03-19 2:16 UTC (permalink / raw)
To: dave; +Cc: qemu-devel, jonathan.cameron, Yao Xingtao
From: Yao Xingtao <yaoxt.fnst@fujitsu.com>
In qemu monitor mode, when we use gpa2hva command to print the host
virtual address corresponding to a guest physical address, if the gpa is
not in RAM, the error message is below:
(qemu) gpa2hva 0x750000000
Memory at address 0x750000000is not RAM
a space is missed between '0x750000000' and 'is'.
Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
---
monitor/hmp-cmds-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
index 9338ae8440..ff01cf9d8d 100644
--- a/monitor/hmp-cmds-target.c
+++ b/monitor/hmp-cmds-target.c
@@ -261,7 +261,7 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
}
if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) {
- error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM", addr);
+ error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr);
memory_region_unref(mrs.mr);
return NULL;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH-for-9.0] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()
2024-03-19 2:16 [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva() Shiyang Ruan via
@ 2024-03-19 12:54 ` Philippe Mathieu-Daudé
2024-03-20 22:42 ` Dr. David Alan Gilbert
2024-03-26 9:58 ` [PATCH] " Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 12:54 UTC (permalink / raw)
To: Shiyang Ruan, dave; +Cc: qemu-devel, jonathan.cameron, Yao Xingtao
On 19/3/24 03:16, Shiyang Ruan via wrote:
> From: Yao Xingtao <yaoxt.fnst@fujitsu.com>
>
> In qemu monitor mode, when we use gpa2hva command to print the host
> virtual address corresponding to a guest physical address, if the gpa is
> not in RAM, the error message is below:
>
> (qemu) gpa2hva 0x750000000
> Memory at address 0x750000000is not RAM
>
> a space is missed between '0x750000000' and 'is'.
>
> Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
> ---
> monitor/hmp-cmds-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
> index 9338ae8440..ff01cf9d8d 100644
> --- a/monitor/hmp-cmds-target.c
> +++ b/monitor/hmp-cmds-target.c
> @@ -261,7 +261,7 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
> }
>
> if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) {
> - error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM", addr);
> + error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr);
> memory_region_unref(mrs.mr);
> return NULL;
> }
Fixes: e9628441df ("hmp: gpa2hva and gpa2hpa hostaddr command")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH-for-9.0] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()
2024-03-19 12:54 ` [PATCH-for-9.0] " Philippe Mathieu-Daudé
@ 2024-03-20 22:42 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2024-03-20 22:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-trivial
Cc: Shiyang Ruan, qemu-devel, jonathan.cameron, Yao Xingtao
* Philippe Mathieu-Daudé (philmd@linaro.org) wrote:
> On 19/3/24 03:16, Shiyang Ruan via wrote:
> > From: Yao Xingtao <yaoxt.fnst@fujitsu.com>
> >
> > In qemu monitor mode, when we use gpa2hva command to print the host
> > virtual address corresponding to a guest physical address, if the gpa is
> > not in RAM, the error message is below:
> >
> > (qemu) gpa2hva 0x750000000
> > Memory at address 0x750000000is not RAM
> >
> > a space is missed between '0x750000000' and 'is'.
> >
> > Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
> > ---
> > monitor/hmp-cmds-target.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
> > index 9338ae8440..ff01cf9d8d 100644
> > --- a/monitor/hmp-cmds-target.c
> > +++ b/monitor/hmp-cmds-target.c
> > @@ -261,7 +261,7 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
> > }
> > if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) {
> > - error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM", addr);
> > + error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr);
> > memory_region_unref(mrs.mr);
> > return NULL;
> > }
>
> Fixes: e9628441df ("hmp: gpa2hva and gpa2hpa hostaddr command")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Cc'ing in Trivial.
Dave
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()
2024-03-19 2:16 [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva() Shiyang Ruan via
2024-03-19 12:54 ` [PATCH-for-9.0] " Philippe Mathieu-Daudé
@ 2024-03-26 9:58 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-26 9:58 UTC (permalink / raw)
To: Shiyang Ruan, dave; +Cc: qemu-devel, jonathan.cameron, Yao Xingtao
On 19/3/24 03:16, Shiyang Ruan via wrote:
> From: Yao Xingtao <yaoxt.fnst@fujitsu.com>
>
> In qemu monitor mode, when we use gpa2hva command to print the host
> virtual address corresponding to a guest physical address, if the gpa is
> not in RAM, the error message is below:
>
> (qemu) gpa2hva 0x750000000
> Memory at address 0x750000000is not RAM
>
> a space is missed between '0x750000000' and 'is'.
>
> Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
> ---
> monitor/hmp-cmds-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, patch queued.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-26 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 2:16 [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva() Shiyang Ruan via
2024-03-19 12:54 ` [PATCH-for-9.0] " Philippe Mathieu-Daudé
2024-03-20 22:42 ` Dr. David Alan Gilbert
2024-03-26 9:58 ` [PATCH] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).