From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1D8CC54E64 for ; Thu, 28 Mar 2024 09:07:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rplif-0004d1-AJ; Thu, 28 Mar 2024 05:06:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rplid-0004cj-R8 for qemu-devel@nongnu.org; Thu, 28 Mar 2024 05:06:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpliQ-0001z9-DA for qemu-devel@nongnu.org; Thu, 28 Mar 2024 05:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711616788; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CTc+xh/U94uk+ZtMXaWTHdHmchgDHDCc5dBoKyl8JWs=; b=BSUX5RtU6Rmo4plmK2DlvC1Tp5Rag52NtkoXh9dfAWfMsaDTcaNKeXpCNBHGk7Ku0WPnXX X2oO1dHk/dwF74cj5HsI/4mbotN4UXaqHkOEaU2G2PPWl6vS/sHF3Fmy9T/CJQ7smV7Bc6 tYPzzFQeW5TsS3I5xQRu8x29ygwJzfc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-7DV6I3S8NGeDjbPZTVBedg-1; Thu, 28 Mar 2024 05:06:25 -0400 X-MC-Unique: 7DV6I3S8NGeDjbPZTVBedg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5B5E9382C47A; Thu, 28 Mar 2024 09:06:24 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18897492BC6; Thu, 28 Mar 2024 09:06:17 +0000 (UTC) Date: Thu, 28 Mar 2024 09:06:11 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Thomas Huth , Marcel Apfelbaum , Yuval Shaia , qemu-block@nongnu.org, "Dr. David Alan Gilbert" , integration@gluster.org, Peter Xu , Markus Armbruster , Paolo Bonzini , Li Zhijian , devel@lists.libvirt.org, Kevin Wolf , Hanna Reitz , Song Gao , Eduardo Habkost , Yanan Wang , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Fabiano Rosas , Eric Blake , Michael Roth , Alex =?utf-8?Q?Benn=C3=A9e?= , Wainer dos Santos Moschetta , Beraldo Leal , Peter Maydell , "Michael S. Tsirkin" , Cornelia Huck Subject: Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device Message-ID: References: <20240327105549.1824-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240327105549.1824-1-philmd@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote: > The whole RDMA subsystem was deprecated in commit e9a54265f5 > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") > released in v8.2. Time to remove it. > > Keep the RAM_SAVE_FLAG_HOOK definition since it might appears > in old migration streams. > > Remove the dependencies on libibumad and libibverbs. > > Remove the generated vmw_pvrdma/ directory from linux-headers. > > Remove RDMA handling from migration. > > Remove RDMA handling in GlusterFS block driver. The RDMA support in GlusterFS is completely opaque to QEMU. All we have there is the CLI syntax to enable use of the RDMA support inside libglusterfs. I'm not convinced that the justification for deprecation (lack of maintanier) applies to this scenario. > Remove rdmacm-mux tool from contrib/. > > Remove PVRDMA device. I agree with Thomas that each functional area listed here should be handld in a separate patch, since they're all independant. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|