From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB3CEC6FD1F for ; Tue, 2 Apr 2024 13:04:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrdnF-0006Mq-75; Tue, 02 Apr 2024 09:03:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrdmE-0005ze-Ng for qemu-devel@nongnu.org; Tue, 02 Apr 2024 09:02:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrdmA-0002WQ-9L for qemu-devel@nongnu.org; Tue, 02 Apr 2024 09:02:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712062923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RbJu5JhscfzLmMEVZM2sY/pfYvXjDWrFhs3X6SyDklc=; b=ZE+C49+9vWgpen0wkJ0SELBiI8m7n0nBpdWG+rOO1kXgSMDZ/6PQkioehF6G/nngPUG619 Pnpazv5gvakfM2lro6cjAZeE/JeBEwYTNMPrVmvpkNNahIe04ifvUgKjAxwtjHNBqhmTqZ hp9dXXWNVoyi3FywaKLBlXiazOhXCWI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-yHf5CL1qOzqgAT7RUWhSVQ-1; Tue, 02 Apr 2024 09:01:57 -0400 X-MC-Unique: yHf5CL1qOzqgAT7RUWhSVQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FC6D80C764; Tue, 2 Apr 2024 13:01:57 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8893C04220; Tue, 2 Apr 2024 13:01:55 +0000 (UTC) Date: Tue, 2 Apr 2024 15:01:50 +0200 From: Kevin Wolf To: Shaoqin Huang Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-arm@nongnu.org, Eric Auger , Peter Maydell , Paolo Bonzini , Thomas Huth , Laurent Vivier , qemu-devel@nongnu.org, kvm@vger.kernel.org, armbru@redhat.com Subject: Re: [PATCH v8] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER Message-ID: References: <20240312074849.71475-1-shahuang@redhat.com> <1881554f-9183-4e01-8cda-0934f7829abf@redhat.com> <46f0c5ab-dee7-4cd4-844d-c418818e187c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46f0c5ab-dee7-4cd4-844d-c418818e187c@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 29.03.2024 um 04:45 hat Shaoqin Huang geschrieben: > Hi Daniel, > > On 3/25/24 16:55, Daniel P. Berrangé wrote: > > On Mon, Mar 25, 2024 at 01:35:58PM +0800, Shaoqin Huang wrote: > > > Hi Daniel, > > > > > > Thanks for your reviewing. I see your comments in the v7. > > > > > > I have some doubts about what you said about the QAPI. Do you want me to > > > convert the current design into the QAPI parsing like the > > > IOThreadVirtQueueMapping? And we need to add new json definition in the > > > qapi/ directory? > > I have defined the QAPI for kvm-pmu-filter like below: > > +## > +# @FilterAction: > +# > +# The Filter Action > +# > +# @a: Allow > +# > +# @d: Disallow > +# > +# Since: 9.0 > +## > +{ 'enum': 'FilterAction', > + 'data': [ 'a', 'd' ] } > + > +## > +# @SingleFilter: > +# > +# Lazy > +# > +# @action: the action > +# > +# @start: the start > +# > +# @end: the end > +# > +# Since: 9.0 > +## > + > +{ 'struct': 'SingleFilter', > + 'data': { 'action': 'FilterAction', 'start': 'int', 'end': 'int' } } > + > +## > +# @KVMPMUFilter: > +# > +# Lazy > +# > +# @filter: the filter > +# > +# Since: 9.0 > +## > + > +{ 'struct': 'KVMPMUFilter', > + 'data': { 'filter': ['SingleFilter'] }} > > And I guess I can use it by adding code like below: > > --- a/hw/core/qdev-properties-system.c > +++ b/hw/core/qdev-properties-system.c > @@ -1206,3 +1206,35 @@ const PropertyInfo qdev_prop_iothread_vq_mapping_list > = { > .set = set_iothread_vq_mapping_list, > .release = release_iothread_vq_mapping_list, > }; > + > +/* --- kvm-pmu-filter ---*/ > + > +static void get_kvm_pmu_filter(Object *obj, Visitor *v, > + const char *name, void *opaque, Error **errp) > +{ > + KVMPMUFilter **prop_ptr = object_field_prop_ptr(obj, opaque); > + > + visit_type_KVMPMUFilter(v, name, prop_ptr, errp); > +} > + > +static void set_kvm_pmu_filter(Object *obj, Visitor *v, > + const char *name, void *opaque, Error **errp) > +{ > + KVMPMUFilter **prop_ptr = object_field_prop_ptr(obj, opaque); > + KVMPMUFilter *list; > + > + printf("running the %s\n", __func__); > + if (!visit_type_KVMPMUFilter(v, name, &list, errp)) { > + return; > + } > + > + printf("The name is %s\n", name); > + *prop_ptr = list; > +} > + > +const PropertyInfo qdev_prop_kvm_pmu_filter = { > + .name = "KVMPMUFilter", > + .description = "der der", > + .get = get_kvm_pmu_filter, > + .set = set_kvm_pmu_filter, > +}; > > +#define DEFINE_PROP_KVM_PMU_FILTER(_name, _state, _field) \ > + DEFINE_PROP(_name, _state, _field, qdev_prop_kvm_pmu_filter, \ > + KVMPMUFilter *) > > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -2439,6 +2441,7 @@ static Property arm_cpu_properties[] = { > mp_affinity, ARM64_AFFINITY_INVALID), > DEFINE_PROP_INT32("node-id", ARMCPU, node_id, CPU_UNSET_NUMA_NODE_ID), > DEFINE_PROP_INT32("core-count", ARMCPU, core_count, -1), > + DEFINE_PROP_KVM_PMU_FILTER("kvm-pmu-filter", ARMCPU, kvm_pmu_filter), > DEFINE_PROP_END_OF_LIST() > }; > > And I guess I can use the new json format input like below: > > qemu-system-aarch64 \ > -cpu host, '{"filter": [{"action": "a", "start": 0x10, "end": "0x11"}]}' > > But it doesn't work. It seems like because the -cpu option doesn't > support json format parameter. > > Maybe I'm wrong. So I want to double check with if the -cpu option > support json format nowadays? As far as I can see, -cpu doesn't support JSON yet. But even if it did, your command line would be invalid because the 'host,' part isn't JSON. > If the -cpu option doesn't support json format, how I can use the QAPI > for kvm-pmu-filter property? This would probably mean QAPIfying all CPUs first, which sounds like a major effort. Kevin