Re: [PATCH v6 0/3] ui/console: Private QemuDmaBuf struct

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Apr 16, 2024 at 09:09:51PM -0700, dongwon.kim@intel.com wrote:
> From: Dongwon Kim <dongwon.kim@intel.com>
> 
> This series introduces privacy enhancements to the QemuDmaBuf struct
> and its contained data to bolster security. it accomplishes this by
> introducing of helper functions for allocating, deallocating, and
> accessing individual fields within the struct and replacing all direct
> references to individual fields in the struct with methods using helpers
> throughout the codebase.

This series feels incomplete wrt the stated goal, because
the QemuDmaBuf struct definition remains public in
console.h at the end.  Ideally only "typedef struct QemuDmaBuf"
should remain in the header, with the struct definiton private
in a .c file.  Is there something that prevents this final step
being done ?


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|