qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Qiang Liu <cyruscyliu@gmail.com>,
	Mauro Matteo Cascella <mcascell@redhat.com>,
	Alexander Bulekov <alxndr@bu.edu>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [PATCH-for-9.0? 0/3] hw/block/nand: Fix out-of-bound access in NAND block buffer
Date: Tue, 9 Apr 2024 12:55:43 +0200	[thread overview]
Message-ID: <ZhUer8fUjnSeOvLu@redhat.com> (raw)
In-Reply-To: <20240408083605.55238-1-philmd@linaro.org>

Am 08.04.2024 um 10:36 hat Philippe Mathieu-Daudé geschrieben:
> Fix for https://gitlab.com/qemu-project/qemu/-/issues/1446
> 
> Philippe Mathieu-Daudé (3):
>   hw/block/nand: Factor nand_load_iolen() method out
>   hw/block/nand: Have blk_load() return boolean indicating success
>   hw/block/nand: Fix out-of-bound access in NAND block buffer

As we're short on time for 9.0:

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

But it feels to me like this device could use some more cleanup to make
the code more robust.

Kevin



      parent reply	other threads:[~2024-04-09 10:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  8:36 [PATCH-for-9.0? 0/3] hw/block/nand: Fix out-of-bound access in NAND block buffer Philippe Mathieu-Daudé
2024-04-08  8:36 ` [PATCH-for-9.0? 1/3] hw/block/nand: Factor nand_load_iolen() method out Philippe Mathieu-Daudé
2024-04-08 16:35   ` Richard Henderson
2024-04-09 10:48   ` Kevin Wolf
2024-04-08  8:36 ` [PATCH-for-9.0? 2/3] hw/block/nand: Have blk_load() return boolean indicating success Philippe Mathieu-Daudé
2024-04-08 16:36   ` Richard Henderson
2024-04-08  8:36 ` [PATCH-for-9.0? 3/3] hw/block/nand: Fix out-of-bound access in NAND block buffer Philippe Mathieu-Daudé
2024-04-08  8:43   ` Philippe Mathieu-Daudé
2024-04-08 16:39   ` Richard Henderson
2024-04-08 22:05     ` Philippe Mathieu-Daudé
2024-04-08 15:45 ` [PATCH-for-9.0? 0/3] " Mauro Matteo Cascella
2024-04-09 13:57   ` Philippe Mathieu-Daudé
2024-04-09 10:55 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhUer8fUjnSeOvLu@redhat.com \
    --to=kwolf@redhat.com \
    --cc=alxndr@bu.edu \
    --cc=cyruscyliu@gmail.com \
    --cc=hreitz@redhat.com \
    --cc=mcascell@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).