qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Peter Dave Hello <hsu@peterdavehello.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
Date: Thu, 18 Apr 2024 10:22:07 +0800	[thread overview]
Message-ID: <ZiCDzzFDRmQGPtDD@intel.com> (raw)
In-Reply-To: <pTgk5-fHZzZe_qQn7RdevQ7Dg9Yz_-I4jWPpYknkgbiStJvLCRlTj9EpfRY_K9GCqdSABB_s_xzuGBCxxRqDfzDIoO6AVcvP-onYk8yRiWI=@peterdavehello.org>

Hi Perter HSU,

On Wed, Apr 17, 2024 at 01:07:17PM +0000, Peter Dave Hello wrote:
> Date: Wed, 17 Apr 2024 13:07:17 +0000
> From: Peter Dave Hello <hsu@peterdavehello.org>
> Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> 
> Hi all,
> 
> Thank you all for the feedback. I've updated the patch to address most of the suggestions, but only the copyright part. I'm not sure how to deal with it. BTW, should I directly paste the revised patch below? Sorry that I'm not familiar with the process here. Thanks for your help again.

New patch should be sent separately to avoid replying directly to
previous mail thread. And the tag of the SUBJECT for your v2 patch needs
to be changed to "[PATCH v2]".

> From: Peter Dave Hello <hsu@peterdavehello.org>
> Date: Tue, 16 Apr 2024 00:43:29 +0800
> Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> 
> This patch adds a basic zh_TW translation file for Taiwan Traditional
> Chinese users.
> 
> Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
> ---
>  po/LINGUAS  |  1 +
>  po/zh_TW.po | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 75 insertions(+)
>  create mode 100644 po/zh_TW.po
> 
> diff --git a/po/LINGUAS b/po/LINGUAS
> index 9b33a36..08163e8 100644
> --- a/po/LINGUAS
> +++ b/po/LINGUAS
> @@ -7,3 +7,4 @@ sv
>  tr
>  uk
>  zh_CN
> +zh_TW
> diff --git a/po/zh_TW.po b/po/zh_TW.po
> new file mode 100644
> index 0000000..e6d2c07
> --- /dev/null
> +++ b/po/zh_TW.po
> @@ -0,0 +1,74 @@
> +# Chinese translations for QEMU package.
> +# Copyright (C) 2024 THE QEMU'S COPYRIGHT HOLDER

Refer to this file /po/bg.po or any other source code of QEMU, copyright
belongs to you or your company.

> +# This file is distributed under the same license as the QEMU package.

You can declare the license by:
"SPDX-License-Identifier: GPL-2.0-or-later".

And put this license under the author line.

> +# Peter Dave Hello <hsu@peterdavehello.org>, 2024.
> +#

Others look good to me. Pls go ahead and respin your v2.

Thanks,
Zhao



  reply	other threads:[~2024-04-18  2:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 11:31 [PATCH] Add zh_TW Traditional Chinese translation Peter Dave Hello
2024-04-16 13:27 ` Peter Maydell
2024-04-16 16:41   ` Zhao Liu
2024-04-16 16:32     ` Daniel P. Berrangé
2024-04-17 13:07       ` Peter Dave Hello
2024-04-18  2:22         ` Zhao Liu [this message]
2024-04-23 18:20           ` Peter Dave Hello
2024-06-21 12:50             ` Peter Dave Hello
2024-06-21 13:07               ` Peter Maydell
2024-06-24 17:06                 ` Daniel P. Berrangé
2025-01-14 13:45                   ` Peter Dave Hello via
2025-01-14 14:34                     ` Daniel P. Berrangé
2024-04-16 16:34 ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZiCDzzFDRmQGPtDD@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=berrange@redhat.com \
    --cc=hsu@peterdavehello.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).