From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB707C25B10 for ; Fri, 10 May 2024 08:11:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5LLO-0008OS-5W; Fri, 10 May 2024 04:11:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5LLI-0008N1-DX for qemu-devel@nongnu.org; Fri, 10 May 2024 04:11:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5LLG-00006L-Fd for qemu-devel@nongnu.org; Fri, 10 May 2024 04:11:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715328656; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCF8vDoIiZlV3N+xDd1DJ/pUXi+5dTBUBfsw74CyAzU=; b=FA/EAWVRTnOgEOxO1d3S+oERmIfEOTggbUjibOwUFEieKJYlqsbREjcGTDmx5At0MpcbOZ OsnTFAViZXC9zjxXt2ARpRroHvnd5KEZMsRR0N0HP7H7UXjtO3Xyq8rHtp6Jc/Hh88Qo+e mHE99P/WUGItg0br5yZw7Zbv+bl7vFA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-q2jpGgdwOU2AhDjrw0_5Og-1; Fri, 10 May 2024 04:10:52 -0400 X-MC-Unique: q2jpGgdwOU2AhDjrw0_5Og-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA14D29AC02A; Fri, 10 May 2024 08:10:51 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C69A72079267; Fri, 10 May 2024 08:10:48 +0000 (UTC) Date: Fri, 10 May 2024 09:10:46 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Michael Tokarev Cc: Babu Moger , pbonzini@redhat.com, richard.henderson@linaro.org, weijiang.yang@intel.com, philmd@linaro.org, dwmw@amazon.co.uk, paul@xen.org, joao.m.martins@oracle.com, qemu-devel@nongnu.org, mtosatti@redhat.com, kvm@vger.kernel.org, mst@redhat.com, marcel.apfelbaum@gmail.com, yang.zhong@intel.com, jing2.liu@intel.com, vkuznets@redhat.com, michael.roth@amd.com, wei.huang2@amd.com, bdas@redhat.com, eduardo@habkost.net, qemu-stable Subject: Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX Message-ID: References: <20240102231738.46553-1-babu.moger@amd.com> <0ee4b0a8293188a53970a2b0e4f4ef713425055e.1714757834.git.babu.moger@amd.com> <89911cf2-7048-4571-a39a-8fa44d7efcda@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.581, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, May 10, 2024 at 11:05:44AM +0300, Michael Tokarev wrote: > 09.05.2024 17:11, Daniel P. Berrangé wrote: > > On Thu, May 09, 2024 at 04:54:16PM +0300, Michael Tokarev wrote: > > > 03.05.2024 20:46, Babu Moger wrote: > > > > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > > > index 08c7de416f..46235466d7 100644 > > > > --- a/hw/i386/pc.c > > > > +++ b/hw/i386/pc.c > > > > @@ -81,6 +81,7 @@ > > > > GlobalProperty pc_compat_9_0[] = { > > > > { TYPE_X86_CPU, "guest-phys-bits", "0" }, > > > > { "sev-guest", "legacy-vm-type", "true" }, > > > > + { TYPE_X86_CPU, "legacy-multi-node", "on" }, > > > > }; > > > > > > Should this legacy-multi-node property be added to previous > > > machine types when applying to stable? How about stable-8.2 > > > and stable-7.2? > > > > machine types are considered to express a fixed guest ABI > > once part of a QEMU release. Given that we should not be > > changing existing machine types in stable branches. > > Yes, I understand this, and this is exactly why I asked. > The change in question has been Cc'ed to stable. And I'm > trying to understand what should I do with it :) > > > In theory we could create new "bug fix" machine types in stable > > branches. To support live migration, we would then need to also > > add those same stable branch "bug fix" machine type versions in > > all future QEMU versions. This is generally not worth the hassle > > of exploding the number of machine types. > > > > If you backport the patch, minus the machine type, then users > > can still get the fix but they'll need to manually set the > > property to enable it. > > I don't think this makes big sense. But maybe for someone who > actually hits this issue such backport will let to fix it. > Hence, again, I'm asking if it really a good idea to pick this > up for stable (any version of, - currently there are 2 active > series, 7.2, 8.2 and 9.0). Hmm, the description says "Observed the following failure while booting the SEV-SNP guest" and yet the patches for SEV-SNP are *not* merged in QEMU yet. So this does not look relevant for stable unless I'm missing something. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|