From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA795C4345F for ; Thu, 2 May 2024 11:14:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2UNQ-0001m7-M7; Thu, 02 May 2024 07:13:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2UNN-0001kq-9E for qemu-devel@nongnu.org; Thu, 02 May 2024 07:13:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2UNJ-0005sa-1u for qemu-devel@nongnu.org; Thu, 02 May 2024 07:13:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714648395; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ReHaOmtWkCTZ24YOjUrIFzDhCHIV1mhDRW5EQbEV5Gs=; b=fB6dZ91ANqt+8Ol7q7V6NzqL8kbs+GGDGs8CW25SVor/lCapl1rj37NgO0WuK7ey4CeubO SLakQVZjqD21Ow+rm2GTKPGcVX91JUuzU+hUO+9q/7yi8g+n1hJ7FG7xc6Z2heMzmznkRK dfIg12FminDtKH53e2dkKhiY7UIEkYc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-TFpbQAWgOiiiWtx94Bj1RA-1; Thu, 02 May 2024 07:13:12 -0400 X-MC-Unique: TFpbQAWgOiiiWtx94Bj1RA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39B8F299E74B; Thu, 2 May 2024 11:13:11 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFB21EC682; Thu, 2 May 2024 11:13:07 +0000 (UTC) Date: Thu, 2 May 2024 12:13:05 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Harsh Prateek Bora , Peter Maydell , Nicholas Piggin , Richard Henderson , Yanan Wang , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?C=C3=A9dric?= Le Goater , Halil Pasic , Laurent Vivier , qemu-arm@nongnu.org, Daniel Henrique Barboza , Eduardo Habkost , qemu-ppc@nongnu.org, David Gibson , Ilya Leoshkevich , Eric Farman , Christian Borntraeger , "Michael S. Tsirkin" , Paolo Bonzini , Marcel Apfelbaum , David Hildenbrand , qemu-s390x@nongnu.org Subject: Re: [PATCH 09/14] hw: temporarily disable deletion of versioned machine types Message-ID: References: <20240501182759.2934195-1-berrange@redhat.com> <20240501182759.2934195-10-berrange@redhat.com> <48986ad1-ae23-4ff1-9494-cae9b485deae@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48986ad1-ae23-4ff1-9494-cae9b485deae@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.476, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, May 02, 2024 at 01:05:20PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > The new deprecation and deletion policy for versioned machine types is > > being introduced in QEMU 9.1.0. > > > > Under the new policy a number of old machine types (any prior to 2.12) > > would be liable for immediate deletion which would be a violation of our > > historical deprecation and removal policy > > > > Thus automatic deletions (by skipping QOM registration) are temporarily > > gated on existance of the env variable "QEMU_DELETE_MACHINES" / QEMU > > version number >= 10.1.0. This allows opt-in testing of the automatic > > deletion logic, while activating it fully in QEMU >= 10.1.0. > > If we include your patches now, the old machine types will be marked as > deprecated in QEMU 9.1 and 9.2, so it should be OK to remove them in 10.0 > already, shouldn't it? Yes, the deprecation marking still happens on the correct documented schedule. We're merely postponing the removal to be nice. IOW, when 10.0 arrives, we'll be able to delete everything upto and including version 4.0, so at that point 4.1 will be the oldest machine present. Without this patch, we would be removing everything upto and including 3.1 straight away with no prior warning. With this patch everything is still present, under the old deprecation 2 release policy. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|