From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD27BC4345F for ; Thu, 2 May 2024 09:55:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2T8V-00077L-Ji; Thu, 02 May 2024 05:53:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2T8P-000744-6c for qemu-devel@nongnu.org; Thu, 02 May 2024 05:53:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2T8K-0000Ox-71 for qemu-devel@nongnu.org; Thu, 02 May 2024 05:53:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714643622; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J/phAWia/j57n0ZJaqcC2oC5SPOPN+MCBg6IHAtFjlA=; b=NQcUDfeENDhcIat4V50TNJNX6eZ/99ehGFMMCYraYsChGhRKTpIhRIwkrbd4v56RyJP+dM vELol7z3AGCeVUmQ1LzEAUD/luGjqyc7tY0CWX6F3r/dWanSu0KL6SBvVzNbhK+7aUnM9b seASu9A7M+ES9UA3jXuib/0jgQ3QBTo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-8tLhLuu3PCy6pD1P10Dw6A-1; Thu, 02 May 2024 05:53:37 -0400 X-MC-Unique: 8tLhLuu3PCy6pD1P10Dw6A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 38058803505; Thu, 2 May 2024 09:53:36 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A7D41C060D0; Thu, 2 May 2024 09:53:32 +0000 (UTC) Date: Thu, 2 May 2024 10:53:30 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Harsh Prateek Bora , Peter Maydell , Nicholas Piggin , Richard Henderson , Yanan Wang , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?C=C3=A9dric?= Le Goater , Halil Pasic , Laurent Vivier , qemu-arm@nongnu.org, Daniel Henrique Barboza , Eduardo Habkost , qemu-ppc@nongnu.org, David Gibson , Ilya Leoshkevich , Eric Farman , Christian Borntraeger , "Michael S. Tsirkin" , Paolo Bonzini , Marcel Apfelbaum , David Hildenbrand , qemu-s390x@nongnu.org Subject: Re: [PATCH 14/14] docs: document special exception for machine type deprecation & removal Message-ID: References: <20240501182759.2934195-1-berrange@redhat.com> <20240501182759.2934195-15-berrange@redhat.com> <8f301d1a-06ec-4c78-9924-a4379f56d0fc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f301d1a-06ec-4c78-9924-a4379f56d0fc@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.897, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, May 02, 2024 at 11:47:40AM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > This extends the deprecation policy to indicate that versioned machine > > types will be marked deprecated after 3 years, and then subject to > > removal after a further 3 years has passed. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > docs/about/deprecated.rst | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > > index 7b8aafa15b..55120e774c 100644 > > --- a/docs/about/deprecated.rst > > +++ b/docs/about/deprecated.rst > > @@ -11,6 +11,18 @@ releases, the feature is liable to be removed. Deprecated features may also > > generate warnings on the console when QEMU starts up, or if activated via a > > monitor command, however, this is not a mandatory requirement. > > +As a special exception to this general timeframe, rather than have an > > +indefinite lifetime, versioned machine types are only intended to be > > +supported for a period of 6 years, equivalent to 18 QEMU releases. All > > +versioned machine types will be automatically marked deprecated after an > > +initial 3 years (9 QEMU releases) has passed, and will then be deleted after > > Should there be the word "period" after "3 years" ? Otherwise it sounds a > little bit weird to me - but I'm also not a native speaker, so I might be > wrong. It would be valid to say either "3 year period" or "3 years", but not "3 years period". > > +a further 3 year period has passed. It is recommended that a deprecated > > +machine type is only used for incoming migrations and restore of saved state, > > +for pre-existing VM deployments. > > Should we maybe add a sentence that they should ideally be updated to a > newer machine type during a service window with downtime? (well, it might be > also obvious, so maybe not worth to mention it) Sure, I'm fine adding something about that, as it helps to steer people in the sane direction. > > Newly deployed VMs should exclusively use a > > +non-deprecated machine type, with use of the most recent version highly > > +recommended. Non-versioned machine types follow the general feature > > +deprecation policy. > > Anyway: > Reviewed-by: Thomas Huth > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|