Re: [PATCH v2] meson.build: add -mcx16 flag for x86_64 host

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, May 23, 2024 at 08:11:18AM +0300, Artyom Kunakovsky wrote:
> Fix linker error if the project was configured by the './configure --cpu=unknown --target-list=riscv64-softmmu' command

As with v1, why are you intentionally passing a bogus CPU target
name to the --cpu arg ?  QEMU already correctly sets '-mcx16' if
you omit --cpu, or pass a correct "x86_64" target name to --cpu.


> 
> Signed-off-by: Artyom Kunakovsky <artyomkunakovsky@gmail.com>
> ---
>  meson.build | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index a9de71d450..e68fbfc662 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -336,6 +336,12 @@ if host_arch == 'i386' and not cc.links('''
>    qemu_common_flags = ['-march=i486'] + qemu_common_flags
>  endif
>  
> +
> +if host_arch == 'x86_64'
> +  qemu_common_flags = ['-mcx16'] + qemu_common_flags
> +endif
> +
> +
>  if get_option('prefer_static')
>    qemu_ldflags += get_option('b_pie') ? '-static-pie' : '-static'
>  endif
> -- 
> 2.25.1
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|