From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Artyom Kunakovsky <artyomkunakovsky@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] meson.build: add -mcx16 flag
Date: Thu, 23 May 2024 10:14:56 +0100 [thread overview]
Message-ID: <Zk8JEJjrXDvMa49q@redhat.com> (raw)
In-Reply-To: <CAFEAcA-jGojmCeE3o=FbghjrSwVWOnKtj-orOtahPaDDv=n2Sg@mail.gmail.com>
On Thu, May 23, 2024 at 09:52:35AM +0100, Peter Maydell wrote:
> On Thu, 23 May 2024 at 09:04, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, May 22, 2024 at 10:30:16PM +0300, Artyom Kunakovsky wrote:
> > > fix linker error if the project was configured by the './configure --cpu=unknown --target-list=riscv64-softmmu' command
> >
> > Isn't this simply user error, with the right answer being
> > to pass a valid CPU target to --cpu, rather than "unknown"
>
> I've felt for ages that we should probably drop the "unrecognized
> host CPU, fall back to TCI" path and insist that we only run
> on recognized CPU types. Then we could also sanity check that
> the user passed a valid --cpu option.
Yeah, I think that's reasonable. Worst case, a user will have to send us a
patch to recognise a new CPU target, at which point at least we know that
it exists as a possible target.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-05-23 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 19:30 [PATCH] meson.build: add -mcx16 flag Artyom Kunakovsky
2024-05-23 8:02 ` Daniel P. Berrangé
2024-05-23 8:35 ` Artyom Kunakovsky
2024-05-23 8:52 ` Peter Maydell
2024-05-23 9:14 ` Daniel P. Berrangé [this message]
2024-05-23 10:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk8JEJjrXDvMa49q@redhat.com \
--to=berrange@redhat.com \
--cc=artyomkunakovsky@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).