* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
@ 2024-05-11 13:54 ` liwei
2024-05-11 17:16 ` Max Chou
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: liwei @ 2024-05-11 13:54 UTC (permalink / raw)
To: Yangyu Chen, qemu-riscv
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Max Chou
On 2024/5/11 19:26, Yangyu Chen wrote:
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Weiwei Li <liwei1518@gmail.com>
Weiwei Li
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
2024-05-11 13:54 ` liwei
@ 2024-05-11 17:16 ` Max Chou
2024-05-11 17:58 ` Yangyu Chen
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Max Chou @ 2024-05-11 17:16 UTC (permalink / raw)
To: Yangyu Chen, qemu-riscv
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei
Reviewed-by: Max Chou <max.chou@sifive.com>
Max
On 2024/5/11 7:26 PM, Yangyu Chen wrote:
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
2024-05-11 13:54 ` liwei
2024-05-11 17:16 ` Max Chou
@ 2024-05-11 17:58 ` Yangyu Chen
2024-05-13 2:57 ` Alistair Francis
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Yangyu Chen @ 2024-05-11 17:58 UTC (permalink / raw)
To: qemu-riscv
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Max Chou
Note: This patch should also backport to stable-v8.2.
> On May 11, 2024, at 19:26, Yangyu Chen <cyy@cyyself.name> wrote:
>
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
` (2 preceding siblings ...)
2024-05-11 17:58 ` Yangyu Chen
@ 2024-05-13 2:57 ` Alistair Francis
2024-05-13 3:29 ` Alistair Francis
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Alistair Francis @ 2024-05-13 2:57 UTC (permalink / raw)
To: Yangyu Chen
Cc: qemu-riscv, qemu-devel, Palmer Dabbelt, Alistair Francis,
Bin Meng, Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei,
Max Chou
On Sat, May 11, 2024 at 9:28 PM Yangyu Chen <cyy@cyyself.name> wrote:
>
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
` (3 preceding siblings ...)
2024-05-13 2:57 ` Alistair Francis
@ 2024-05-13 3:29 ` Alistair Francis
2024-05-13 7:18 ` Yangyu Chen
2024-05-13 12:21 ` Daniel Henrique Barboza
6 siblings, 0 replies; 9+ messages in thread
From: Alistair Francis @ 2024-05-13 3:29 UTC (permalink / raw)
To: Yangyu Chen
Cc: qemu-riscv, qemu-devel, Palmer Dabbelt, Alistair Francis,
Bin Meng, Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei,
Max Chou
On Sat, May 11, 2024 at 9:28 PM Yangyu Chen <cyy@cyyself.name> wrote:
>
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
` (4 preceding siblings ...)
2024-05-13 3:29 ` Alistair Francis
@ 2024-05-13 7:18 ` Yangyu Chen
2024-05-16 14:01 ` Hongren Zheng
2024-05-13 12:21 ` Daniel Henrique Barboza
6 siblings, 1 reply; 9+ messages in thread
From: Yangyu Chen @ 2024-05-13 7:18 UTC (permalink / raw)
To: qemu-riscv
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Max Chou, qemu-stable
I think this patch also needs to back-port to stable-8.2.
I added qemu-stable@nongnu.org to cc.
> On May 11, 2024, at 19:26, Yangyu Chen <cyy@cyyself.name> wrote:
>
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-13 7:18 ` Yangyu Chen
@ 2024-05-16 14:01 ` Hongren Zheng
0 siblings, 0 replies; 9+ messages in thread
From: Hongren Zheng @ 2024-05-16 14:01 UTC (permalink / raw)
To: Yangyu Chen
Cc: qemu-riscv, qemu-devel, Palmer Dabbelt, Alistair Francis,
Bin Meng, Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei,
Max Chou, qemu-stable
On Mon, May 13, 2024 at 03:18:53PM +0800, Yangyu Chen wrote:
> I think this patch also needs to back-port to stable-8.2.
Indeed, downstream OpenSSL CI using Ubuntu 24.04, which ships
QEMU 8.2.2, encountered this bug and that is quite confusing
QEMU 9.0.0 is also affected
Links
https://github.com/openssl/openssl/pull/24403/commits/5f7750fa0d366fd87d3280c18f7539f720a8d0be
https://github.com/openssl/openssl/pull/24403#issuecomment-2115320298
>
> I added qemu-stable@nongnu.org to cc.
>
> > On May 11, 2024, at 19:26, Yangyu Chen <cyy@cyyself.name> wrote:
> >
> > This code has a typo that writes zvkb to zvkg, causing users can't
> > enable zvkb through the config. This patch gets this fixed.
> >
> > Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> > Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> > Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> > ---
> > target/riscv/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > index eb1a2e7d6d..13cd34adbd 100644
> > --- a/target/riscv/cpu.c
> > +++ b/target/riscv/cpu.c
> > @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> > /* Vector cryptography extensions */
> > MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> > MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> > - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> > + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> > MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> > MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> > MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> > --
> > 2.43.0
> >
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
` (5 preceding siblings ...)
2024-05-13 7:18 ` Yangyu Chen
@ 2024-05-13 12:21 ` Daniel Henrique Barboza
6 siblings, 0 replies; 9+ messages in thread
From: Daniel Henrique Barboza @ 2024-05-13 12:21 UTC (permalink / raw)
To: Yangyu Chen, qemu-riscv
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng, Weiwei Li,
Liu Zhiwei, Max Chou, Michael Tokarev
On 5/11/24 08:26, Yangyu Chen wrote:
> This code has a typo that writes zvkb to zvkg, causing users can't
> enable zvkb through the config. This patch gets this fixed.
My bad!
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> ---
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Michael, here's another one for stable.
Thanks,
Daniel
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index eb1a2e7d6d..13cd34adbd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> /* Vector cryptography extensions */
> MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
^ permalink raw reply [flat|nested] 9+ messages in thread