From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCD1BC25B78 for ; Fri, 17 May 2024 09:05:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7tWS-0006r0-QZ; Fri, 17 May 2024 05:05:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7tWG-0006p4-Vx for qemu-devel@nongnu.org; Fri, 17 May 2024 05:04:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7tWE-0004br-NB for qemu-devel@nongnu.org; Fri, 17 May 2024 05:04:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715936689; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/qivQabUSqLzPY1ZQqxIcQx9k/kDu9H6OQiuJDMeAw=; b=iZczp6hFA8DttaPI4cWzXyI4G8JmsBGlwaZwRtLB0Y4WtYP/OBcxk3/ANbtdwr1ZF97kz3 Rwhpr/BeG+JII7ry35JlnCMSJJ+sS2tdu0ZdAAq2mAKTFjac5j2PMLuWCZIvUBxQW+wYBS Q4bmWaFyfCOHfC0swvw37mUrYgxoHlw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-ut0yvIhvOh-VLAlPDqqNBA-1; Fri, 17 May 2024 05:04:45 -0400 X-MC-Unique: ut0yvIhvOh-VLAlPDqqNBA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C55885A58C; Fri, 17 May 2024 09:04:45 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4291F740F; Fri, 17 May 2024 09:04:44 +0000 (UTC) Date: Fri, 17 May 2024 10:04:41 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Thomas Huth , Paolo Bonzini , Laurent Vivier Subject: Re: [PATCH v2 1/3] crypto: Remove 'crypto-tls-x509-helpers.h' from crypto-tls-psk-helpers.c Message-ID: References: <20240502095642.93368-1-philmd@linaro.org> <20240502095642.93368-2-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240502095642.93368-2-philmd@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.022, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, May 02, 2024 at 11:56:40AM +0200, Philippe Mathieu-Daudé wrote: > crypto-tls-psk-helpers.c doesn't access the declarations > of "crypto-tls-x509-helpers.h", remove the include line > to avoid when building with GNUTLS but without Libtasn1: > > In file included from tests/unit/crypto-tls-psk-helpers.c:23: > tests/unit/crypto-tls-x509-helpers.h:26:10: fatal error: > libtasn1.h: No such file or directory > 26 | #include > | ^~~~~~~~~~~~ > compilation terminated. > > Fixes: e1a6dc91dd ("crypto: Implement TLS Pre-Shared Keys (PSK).") > Suggested-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/unit/crypto-tls-psk-helpers.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|