From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: peter.maydell@linaro.org, laurent@vivier.eu,
mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq'
Date: Mon, 20 May 2024 13:22:39 +0000 [thread overview]
Message-ID: <ZktOn_j2dDdDZclF@gallifrey> (raw)
In-Reply-To: <20240505171444.333302-4-dave@treblig.org>
* Dr. David Alan Gilbert (dave@treblig.org) wrote:
> This struct is unused since Peter's
> Commit b8ae597f0e6d ("linux-user/sparc: Fix errors in target_ucontext
> structures")
>
> However, hmm, I'm a bit confused since that commit modifies the
> structure and then removes it, was that intentional?
Ping on this.
(I think the others in the set have been reviewed and one picked up).
Dave
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> linux-user/sparc/signal.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c
> index f164b74032..8181b8b92c 100644
> --- a/linux-user/sparc/signal.c
> +++ b/linux-user/sparc/signal.c
> @@ -546,11 +546,6 @@ void setup_sigtramp(abi_ulong sigtramp_page)
> typedef abi_ulong target_mc_greg_t;
> typedef target_mc_greg_t target_mc_gregset_t[SPARC_MC_NGREG];
>
> -struct target_mc_fq {
> - abi_ulong mcfq_addr;
> - uint32_t mcfq_insn;
> -};
> -
> /*
> * Note the manual 16-alignment; the kernel gets this because it
> * includes a "long double qregs[16]" in the mcpu_fregs union,
> --
> 2.45.0
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-05-20 13:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 17:14 [PATCH 0/7] Remove some unused structures Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame' Dr. David Alan Gilbert
2024-05-05 17:33 ` Richard Henderson
2024-05-05 17:14 ` [PATCH 2/7] linux-user: i386/signal: Remove unused fp structs Dr. David Alan Gilbert
2024-05-05 17:35 ` Richard Henderson
2024-05-05 18:33 ` Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq' Dr. David Alan Gilbert
2024-05-20 13:22 ` Dr. David Alan Gilbert [this message]
2024-05-05 17:14 ` [PATCH 4/7] hw/usb/dev-network: Remove unused struct 'rndis_config_parameter' Dr. David Alan Gilbert
2024-05-06 7:37 ` Philippe Mathieu-Daudé
2024-05-05 17:14 ` [PATCH 5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass' Dr. David Alan Gilbert
2024-05-06 7:40 ` Philippe Mathieu-Daudé
2024-05-05 17:14 ` [PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32' Dr. David Alan Gilbert
2024-05-05 18:52 ` BALATON Zoltan
2024-05-10 12:43 ` BALATON Zoltan
2024-05-10 12:49 ` Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 7/7] net/can: Remove unused struct 'CanBusState' Dr. David Alan Gilbert
2024-05-06 7:43 ` Philippe Mathieu-Daudé
2024-06-07 14:04 ` [PATCH 0/7] Remove some unused structures Dr. David Alan Gilbert
2024-06-17 12:59 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZktOn_j2dDdDZclF@gallifrey \
--to=dave@treblig.org \
--cc=atar4qemu@gmail.com \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).