From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC43BC25B7E for ; Tue, 4 Jun 2024 08:51:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEPsm-0007p8-H7; Tue, 04 Jun 2024 04:51:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEPsk-0007nU-F3; Tue, 04 Jun 2024 04:51:02 -0400 Received: from mgamail.intel.com ([192.198.163.9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEPsh-0002ZG-HR; Tue, 04 Jun 2024 04:51:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717491059; x=1749027059; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ap8E/rEAx1h96bUEuIBQzglwJ4IPaipb0Em35hfeCMI=; b=ZgQ5ODMYRJA5ogiEGqo68OAdZGOuXkFosYZCqP4YOqO7gd+e8YKeDqfk l9PHzZihP+BwGyIkVK4VIrYaPmxpfmsKsjvuEVS6Lxb6B3j2Ixj+AvzuH OTvENLEbAsHXQVpgrSEa/jSCo6Je24wRAMGsbCLwsmT38uexegQIxCrKZ Nrvta8wMUwkTf1i/7pSfXLDwBPXiycEOCaqsTivrN/zTd0FBKc2eYhD0l cWzOzIzxsf4A3oeOgWNqd0EPNg0SQG+Rw9nPD6lFCWLSo9IkL9hJT9SdF fafNZvGv61nbhMcK3lx8kL98xcr523jVBgxWVOma+2cIe/TVgLPrMntCv w==; X-CSE-ConnectionGUID: MxoCOuMPSCKBfpurCbRG+A== X-CSE-MsgGUID: ehPuF1c0R/iAwCLcNuK6lQ== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="24686290" X-IronPort-AV: E=Sophos;i="6.08,213,1712646000"; d="scan'208";a="24686290" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 01:50:55 -0700 X-CSE-ConnectionGUID: xgrFahFxRWmNqr5Axiqaqw== X-CSE-MsgGUID: 4ZpV1M0jS6m9NzOxuga+5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,213,1712646000"; d="scan'208";a="68338779" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by fmviesa001.fm.intel.com with ESMTP; 04 Jun 2024 01:50:50 -0700 Date: Tue, 4 Jun 2024 17:06:16 +0800 From: Zhao Liu To: Markus Armbruster Cc: Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Eduardo Habkost , Marcel Apfelbaum , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Yanan Wang , "Michael S . Tsirkin" , Paolo Bonzini , Richard Henderson , Eric Blake , Marcelo Tosatti , Alex =?iso-8859-1?Q?Benn=E9e?= , Peter Maydell , Jonathan Cameron , Sia Jee Heng , qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Zhenyu Wang , Dapeng Mi , Yongwei Ma Subject: Re: [RFC v2 1/7] hw/core: Make CPU topology enumeration arch-agnostic Message-ID: References: <20240530101539.768484-1-zhao1.liu@intel.com> <20240530101539.768484-2-zhao1.liu@intel.com> <87plsyfc1r.fsf@pond.sub.org> <87zfs19jrj.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zfs19jrj.fsf@pond.sub.org> Received-SPF: pass client-ip=192.198.163.9; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jun 04, 2024 at 10:47:44AM +0200, Markus Armbruster wrote: > Date: Tue, 04 Jun 2024 10:47:44 +0200 > From: Markus Armbruster > Subject: Re: [RFC v2 1/7] hw/core: Make CPU topology enumeration > arch-agnostic > > Zhao Liu writes: > > > Hi Markus, > > > > On Mon, Jun 03, 2024 at 02:25:36PM +0200, Markus Armbruster wrote: > >> Date: Mon, 03 Jun 2024 14:25:36 +0200 > >> From: Markus Armbruster > >> Subject: Re: [RFC v2 1/7] hw/core: Make CPU topology enumeration > >> arch-agnostic > >> > >> Zhao Liu writes: > >> > >> > Cache topology needs to be defined based on CPU topology levels. Thus, > >> > define CPU topology enumeration in qapi/machine.json to make it generic > >> > for all architectures. > >> > > >> > To match the general topology naming style, rename CPU_TOPO_LEVEL_SMT > >> > and CPU_TOPO_LEVEL_PACKAGE to CPU_TOPO_LEVEL_THREAD and > >> > CPU_TOPO_LEVEL_SOCKET. > >> > > >> > Also, enumerate additional topology levels for non-i386 arches, and add > >> > helpers for topology enumeration and string conversion. > >> > > >> > Signed-off-by: Zhao Liu > >> > >> [...] > >> > >> > diff --git a/qapi/machine.json b/qapi/machine.json > >> > index bce6e1bbc412..7ac5a05bb9c9 100644 > >> > --- a/qapi/machine.json > >> > +++ b/qapi/machine.json > >> > @@ -1667,6 +1667,46 @@ > >> > '*reboot-timeout': 'int', > >> > '*strict': 'bool' } } > >> > > >> > +## > >> > +# @CPUTopoLevel: > >> > >> I understand you're moving existing enum CPUTopoLevel into the QAPI > >> schema. I think the idiomatic QAPI name would be CpuTopologyLevel. > >> Would you be willing to rename it, or would that be too much churn? > > > > Sure, I'll rename it as you suggested. > > > >> > +# > >> > +# An enumeration of CPU topology levels. > >> > +# > >> > +# @invalid: Invalid topology level, used as a placeholder. > >> > +# > >> > +# @thread: thread level, which would also be called SMT level or logical > >> > +# processor level. The @threads option in -smp is used to configure > >> > +# the topology of this level. > >> > +# > >> > +# @core: core level. The @cores option in -smp is used to configure the > >> > +# topology of this level. > >> > +# > >> > +# @module: module level. The @modules option in -smp is used to > >> > +# configure the topology of this level. > >> > +# > >> > +# @cluster: cluster level. The @clusters option in -smp is used to > >> > +# configure the topology of this level. > >> > +# > >> > +# @die: die level. The @dies option in -smp is used to configure the > >> > +# topology of this level. > >> > +# > >> > +# @socket: socket level, which would also be called package level. The > >> > +# @sockets option in -smp is used to configure the topology of this > >> > +# level. > >> > +# > >> > +# @book: book level. The @books option in -smp is used to configure the > >> > +# topology of this level. > >> > +# > >> > +# @drawer: drawer level. The @drawers option in -smp is used to > >> > +# configure the topology of this level. > >> > >> docs/devel/qapi-code-gen.rst section Documentation markup: > >> > >> For legibility, wrap text paragraphs so every line is at most 70 > >> characters long. > >> > >> Separate sentences with two spaces. > > > > Thank you for pointing this. > > > > About separating sentences, is this what I should be doing? > > > > # @drawer: drawer level. The @drawers option in -smp is used to > > # configure the topology of this level. > > Like this: > > ## > # @CPUTopoLevel: > # > # An enumeration of CPU topology levels. > # > # @invalid: Invalid topology level. > # > # @thread: thread level, which would also be called SMT level or > # logical processor level. The @threads option in -smp is used to > # configure the topology of this level. > # > # @core: core level. The @cores option in -smp is used to configure > # the topology of this level. > # > # @module: module level. The @modules option in -smp is used to > # configure the topology of this level. > # > # @cluster: cluster level. The @clusters option in -smp is used to > # configure the topology of this level. > # > # @die: die level. The @dies option in -smp is used to configure the > # topology of this level. > # > # @socket: socket level, which would also be called package level. > # The @sockets option in -smp is used to configure the topology of > # this level. > # > # @book: book level. The @books option in -smp is used to configure > # the topology of this level. > # > # @drawer: drawer level. The @drawers option in -smp is used to > # configure the topology of this level. > # > # Since: 9.1 > ## > I see, thanks very much for your patience.