From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AB9BC25B7E for ; Tue, 28 May 2024 16:06:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBzLI-0005Yq-Ox; Tue, 28 May 2024 12:06:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBzLG-0005Qn-M3 for qemu-devel@nongnu.org; Tue, 28 May 2024 12:06:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBzLF-0008IT-1V for qemu-devel@nongnu.org; Tue, 28 May 2024 12:06:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716912382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZztO8VGMU/DAbJAUY2lbfDZen81X1/5vsAMFVdBQqkY=; b=FZIP51ahYBZsKzbR5cIvNEeSIMsI3+0GMf+1s1SkXPpWHwhiY5I2w3y6XuDoC7R5vDFEdH 6E6lmMzZ3w6aap6uFZBJDtMdgnh1f/S7Oebk2Cy6z2hKP7rY+q9FTQw0HtheLaMZajoVsG jSC6Jlw+nV6Zx54CXsHeJqTq+sJh7/U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-KMnRXSDoPYu-ctZK4sky9w-1; Tue, 28 May 2024 12:06:17 -0400 X-MC-Unique: KMnRXSDoPYu-ctZK4sky9w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D2C6800CAC; Tue, 28 May 2024 16:06:16 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C41022026D68; Tue, 28 May 2024 16:06:14 +0000 (UTC) Date: Tue, 28 May 2024 18:06:13 +0200 From: Kevin Wolf To: Fiona Ebner Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org, hreitz@redhat.com, vsementsov@yandex-team.ru, jsnow@redhat.com, f.weber@proxmox.com Subject: Re: [PATCH] block/copy-before-write: use uint64_t for timeout in nanoseconds Message-ID: References: <20240429141934.442154-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429141934.442154-1-f.ebner@proxmox.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 29.04.2024 um 16:19 hat Fiona Ebner geschrieben: > rather than the uint32_t for which the maximum is slightly more than 4 > seconds and larger values would overflow. The QAPI interface allows > specifying the number of seconds, so only values 0 to 4 are safe right > now, other values lead to a much lower timeout than a user expects. > > The block_copy() call where this is used already takes a uint64_t for > the timeout, so no change required there. > > Fixes: 6db7fd1ca9 ("block/copy-before-write: implement cbw-timeout option") > Reported-by: Friedrich Weber > Signed-off-by: Fiona Ebner Thanks, applied to the block branch. But I don't think our job is done yet with this. Increasing the limit is good and useful, but even if it's now unlikely to hit with sane values, we should still catch integer overflows in cbw_open() and return an error on too big values instead of silently wrapping around. Kevin