From: Peter Xu <peterx@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org
Subject: Re: [PATCH] tests/qtest/migrate-test: Use regular file file for shared-memory tests
Date: Tue, 28 May 2024 20:46:53 -0400 [thread overview]
Message-ID: <ZlZ6_cJmxMkMmVKo@x1n> (raw)
In-Reply-To: <D1LOU3F9ZD3Q.3KYRK41PZT98O@gmail.com>
On Wed, May 29, 2024 at 10:05:32AM +1000, Nicholas Piggin wrote:
> I think that's good if you _need_ shm (e.g., for a uffd test), but
> we should permit tests that only require a memory file.
Yes there's no reason to forbid that, it's just that we're not adding new
tests but we can potentially change any future use_shmem to not test shmem
anymore.. instead we test something we don't suggest users to use..
The only concern is a small /dev/shm mount, am I right? Would it work if
switch to memory-backend-memfd,shared=on?
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2024-05-29 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 4:27 [PATCH] tests/qtest/migrate-test: Use regular file file for shared-memory tests Nicholas Piggin
2024-05-28 13:35 ` Peter Xu
2024-05-28 16:05 ` Peter Xu
2024-05-28 18:16 ` Fabiano Rosas
2024-05-29 0:05 ` Nicholas Piggin
2024-05-29 0:46 ` Peter Xu [this message]
2024-05-28 13:51 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlZ6_cJmxMkMmVKo@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).