* [PATCH] target/i386: fix SSE and SSE2 featue check
@ 2024-06-02 10:09 lixinyu20s
2024-06-02 10:48 ` Zhao Liu
2024-06-03 7:21 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: lixinyu20s @ 2024-06-02 10:09 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, richard.henderson, eduardo, Xinyu Li, Xinyu Li
From: Xinyu Li <lixinyu@loongson.cn>
Featues check of CPUID_SSE and CPUID_SSE2 shoule use cpuid_features,
rather than cpuid_ext_features
Signed-off-by: Xinyu Li <lixinyu20s@ict.ac.cn>
---
target/i386/tcg/decode-new.c.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc
index 27dc1bb146..0ec849b003 100644
--- a/target/i386/tcg/decode-new.c.inc
+++ b/target/i386/tcg/decode-new.c.inc
@@ -2041,9 +2041,9 @@ static bool has_cpuid_feature(DisasContext *s, X86CPUIDFeature cpuid)
case X86_FEAT_PCLMULQDQ:
return (s->cpuid_ext_features & CPUID_EXT_PCLMULQDQ);
case X86_FEAT_SSE:
- return (s->cpuid_ext_features & CPUID_SSE);
+ return (s->cpuid_features & CPUID_SSE);
case X86_FEAT_SSE2:
- return (s->cpuid_ext_features & CPUID_SSE2);
+ return (s->cpuid_features & CPUID_SSE2);
case X86_FEAT_SSE3:
return (s->cpuid_ext_features & CPUID_EXT_SSE3);
case X86_FEAT_SSSE3:
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] target/i386: fix SSE and SSE2 featue check
2024-06-02 10:09 [PATCH] target/i386: fix SSE and SSE2 featue check lixinyu20s
@ 2024-06-02 10:48 ` Zhao Liu
2024-06-04 9:42 ` Fiona Ebner
2024-06-03 7:21 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Zhao Liu @ 2024-06-02 10:48 UTC (permalink / raw)
To: lixinyu20s; +Cc: qemu-devel, pbonzini, richard.henderson, eduardo, Xinyu Li
On Sun, Jun 02, 2024 at 06:09:04PM +0800, lixinyu20s@ict.ac.cn wrote:
> Date: Sun, 2 Jun 2024 18:09:04 +0800
> From: lixinyu20s@ict.ac.cn
> Subject: [PATCH] target/i386: fix SSE and SSE2 featue check
> X-Mailer: git-send-email 2.34.1
>
> From: Xinyu Li <lixinyu@loongson.cn>
>
> Featues check of CPUID_SSE and CPUID_SSE2 shoule use cpuid_features,
> rather than cpuid_ext_features
It's better to add a Fixes tag,
Fixes: caa01fadbef1 ("target/i386: add CPUID feature checks to new decoder")
> Signed-off-by: Xinyu Li <lixinyu20s@ict.ac.cn>
> ---
> target/i386/tcg/decode-new.c.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/i386: fix SSE and SSE2 featue check
2024-06-02 10:09 [PATCH] target/i386: fix SSE and SSE2 featue check lixinyu20s
2024-06-02 10:48 ` Zhao Liu
@ 2024-06-03 7:21 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2024-06-03 7:21 UTC (permalink / raw)
To: lixinyu20s; +Cc: qemu-devel, pbonzini, richard.henderson, eduardo, Xinyu Li
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/i386: fix SSE and SSE2 featue check
2024-06-02 10:48 ` Zhao Liu
@ 2024-06-04 9:42 ` Fiona Ebner
0 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2024-06-04 9:42 UTC (permalink / raw)
To: Zhao Liu, lixinyu20s
Cc: qemu-devel, pbonzini, richard.henderson, eduardo, Xinyu Li,
qemu-stable
Am 02.06.24 um 12:48 schrieb Zhao Liu:
> On Sun, Jun 02, 2024 at 06:09:04PM +0800, lixinyu20s@ict.ac.cn wrote:
>> Date: Sun, 2 Jun 2024 18:09:04 +0800
>> From: lixinyu20s@ict.ac.cn
>> Subject: [PATCH] target/i386: fix SSE and SSE2 featue check
>> X-Mailer: git-send-email 2.34.1
>>
>> From: Xinyu Li <lixinyu@loongson.cn>
>>
>> Featues check of CPUID_SSE and CPUID_SSE2 shoule use cpuid_features,
>> rather than cpuid_ext_features
>
> It's better to add a Fixes tag,
>
> Fixes: caa01fadbef1 ("target/i386: add CPUID feature checks to new decoder")
>
CC-ing stable, because caa01fadbef1 has been there since v7.2.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-04 9:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-02 10:09 [PATCH] target/i386: fix SSE and SSE2 featue check lixinyu20s
2024-06-02 10:48 ` Zhao Liu
2024-06-04 9:42 ` Fiona Ebner
2024-06-03 7:21 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).