From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: peter.maydell@linaro.org, laurent@vivier.eu, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 0/7] Remove some unused structures
Date: Fri, 7 Jun 2024 14:04:26 +0000 [thread overview]
Message-ID: <ZmMTPvLUaB4tGvbk@gallifrey> (raw)
In-Reply-To: <20240505171444.333302-1-dave@treblig.org>
* Dr. David Alan Gilbert (dave@treblig.org) wrote:
> A bunch of structs that are currently unused,
> found with a simple script and a bit of eyeballing.
>
> The only one I'm that suspicious of is the SPARC
> one, where the patch which removed the use is a bit
> confusing to me.
Copying in Trivial; I think there are 4 of these that
are still outstanding:
[PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame'
(Although cris is going)
[PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq'
[PATCH 5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass'
[PATCH 7/7] net/can: Remove unused struct 'CanBusState'
Can Trivial pick these up please?
Dave
> Tested with a
> --target-list=ppc-softmmu,m68k-softmmu,x86_64-softmmu,arm-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user
> and 'make check' on x86 linux.
>
> Dave
>
> Dr. David Alan Gilbert (7):
> linux-user: cris: Remove unused struct 'rt_signal_frame'
> linux-user: i386/signal: Remove unused fp structs
> linux-user: sparc: Remove unused struct 'target_mc_fq'
> hw/usb/dev-network: Remove unused struct 'rndis_config_parameter'
> hw/arm/bcm2836: Remove unusued struct 'BCM283XClass'
> target/ppc: Remove unused struct 'mmu_ctx_hash32'
> net/can: Remove unused struct 'CanBusState'
>
> hw/arm/bcm2836.c | 12 ------------
> hw/usb/dev-network.c | 8 --------
> linux-user/cris/signal.c | 8 --------
> linux-user/i386/signal.c | 10 ----------
> linux-user/sparc/signal.c | 5 -----
> net/can/can_host.c | 6 ------
> target/ppc/mmu-hash32.c | 6 ------
> 7 files changed, 55 deletions(-)
>
> --
> 2.45.0
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-06-07 14:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 17:14 [PATCH 0/7] Remove some unused structures Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame' Dr. David Alan Gilbert
2024-05-05 17:33 ` Richard Henderson
2024-05-05 17:14 ` [PATCH 2/7] linux-user: i386/signal: Remove unused fp structs Dr. David Alan Gilbert
2024-05-05 17:35 ` Richard Henderson
2024-05-05 18:33 ` Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq' Dr. David Alan Gilbert
2024-05-20 13:22 ` Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 4/7] hw/usb/dev-network: Remove unused struct 'rndis_config_parameter' Dr. David Alan Gilbert
2024-05-06 7:37 ` Philippe Mathieu-Daudé
2024-05-05 17:14 ` [PATCH 5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass' Dr. David Alan Gilbert
2024-05-06 7:40 ` Philippe Mathieu-Daudé
2024-05-05 17:14 ` [PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32' Dr. David Alan Gilbert
2024-05-05 18:52 ` BALATON Zoltan
2024-05-10 12:43 ` BALATON Zoltan
2024-05-10 12:49 ` Dr. David Alan Gilbert
2024-05-05 17:14 ` [PATCH 7/7] net/can: Remove unused struct 'CanBusState' Dr. David Alan Gilbert
2024-05-06 7:43 ` Philippe Mathieu-Daudé
2024-06-07 14:04 ` Dr. David Alan Gilbert [this message]
2024-06-17 12:59 ` [PATCH 0/7] Remove some unused structures Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmMTPvLUaB4tGvbk@gallifrey \
--to=dave@treblig.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).