From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Eric Blake" <eblake@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Don Porter" <porter@cs.unc.edu>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>,
qemu-ppc@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH 1/2] hw/intc: Avoid using Monitor in INTERRUPT_STATS_PROVIDER::print_info()
Date: Mon, 10 Jun 2024 09:35:29 +0100 [thread overview]
Message-ID: <Zma60WL9eknYfg1a@redhat.com> (raw)
In-Reply-To: <20240610063518.50680-2-philmd@linaro.org>
On Mon, Jun 10, 2024 at 08:35:16AM +0200, Philippe Mathieu-Daudé wrote:
> Replace Monitor API by HumanReadableText one (see commit f2de406f29
> "docs/devel: document expectations for QAPI data modelling for QMP"
> for rationale).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/intc/intc.h | 2 +-
> hw/intc/goldfish_pic.c | 8 +++---
> hw/intc/i8259_common.c | 14 +++++-----
> hw/intc/ioapic_common.c | 57 +++++++++++++++++++++--------------------
> hw/intc/m68k_irqc.c | 5 ++--
> hw/intc/slavio_intctl.c | 11 ++++----
> hw/ppc/pnv.c | 10 +-------
> hw/ppc/spapr.c | 10 +-------
> monitor/hmp-cmds.c | 8 +++++-
> 9 files changed, 57 insertions(+), 68 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-06-10 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 6:35 [PATCH 0/2] hw/intc: Introduce x-query-interrupt-controllers QMP command Philippe Mathieu-Daudé
2024-06-10 6:35 ` [PATCH 1/2] hw/intc: Avoid using Monitor in INTERRUPT_STATS_PROVIDER::print_info() Philippe Mathieu-Daudé
2024-06-10 8:35 ` Daniel P. Berrangé [this message]
2024-06-10 6:35 ` [PATCH 2/2] hw/intc: Introduce x-query-interrupt-controllers QMP command Philippe Mathieu-Daudé
2024-06-10 8:35 ` Daniel P. Berrangé
2024-06-18 11:00 ` [PATCH 0/2] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zma60WL9eknYfg1a@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=dave@treblig.org \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=fbarrat@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=porter@cs.unc.edu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).