From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73EB1C27C5E for ; Tue, 11 Jun 2024 14:12:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sH2E0-0001yB-P8; Tue, 11 Jun 2024 10:11:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH2Dy-0001xI-N9 for qemu-devel@nongnu.org; Tue, 11 Jun 2024 10:11:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH2Du-00034d-SI for qemu-devel@nongnu.org; Tue, 11 Jun 2024 10:11:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718115102; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LwSS7YgG3Q6NyNlX9/YU5BlUxQGdNbLKUa1J0Mf1cKg=; b=EkHGnouweVUgibCzrqSegEVku26AMuC2xCsXb+eTuUgoQi3AuxGwyt9G0C5Agjz+omF8Al ziwcpbc07J/pF8afJYY0W9berATAzlha1reldG4zqUcUx45Tovhy5Ehbq0ghRNKnWvGuAh 4NqlyjZq2a/H7QW8Gzlo7blnUvIF7q8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-7gmaVXOIOra83wXtpq6HpQ-1; Tue, 11 Jun 2024 10:11:36 -0400 X-MC-Unique: 7gmaVXOIOra83wXtpq6HpQ-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97C60195608A; Tue, 11 Jun 2024 14:11:34 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.73]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D352819560AF; Tue, 11 Jun 2024 14:11:26 +0000 (UTC) Date: Tue, 11 Jun 2024 15:11:23 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: Manos Pitsidianakis , qemu-devel@nongnu.org, Stefan Hajnoczi , Mads Ynddal , Peter Maydell , Alex =?utf-8?Q?Benn=C3=A9e?= , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Thomas Huth , Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Zhao Liu , Gustavo Romero , Pierrick Bouvier Subject: Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.141, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jun 11, 2024 at 03:16:19PM +0200, Paolo Bonzini wrote: > On Tue, Jun 11, 2024 at 10:22 AM Daniel P. Berrangé wrote: > > > > On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > > > Hello everyone, > > > > > > This is an early draft of my work on implementing a very simple device, > > > in this case the ARM PL011 (which in C code resides in hw/char/pl011.c > > > and is used in hw/arm/virt.c). > > > > looking at the diffstat: > > > > > .gitignore | 2 + > > > .gitlab-ci.d/buildtest.yml | 64 ++-- > > > configure | 12 + > > > hw/arm/virt.c | 2 +- > > > meson.build | 99 ++++++ > > > meson_options.txt | 4 + > > > rust/meson.build | 93 ++++++ > > > rust/pl011/.cargo/config.toml | 2 + > > > rust/pl011/.gitignore | 2 + > > > rust/pl011/Cargo.lock | 120 +++++++ > > > rust/pl011/Cargo.toml | 26 ++ > > > rust/pl011/README.md | 42 +++ > > > rust/pl011/build.rs | 44 +++ > > > rust/pl011/meson.build | 7 + > > > rust/pl011/rustfmt.toml | 10 + > > > rust/pl011/src/definitions.rs | 95 ++++++ > > > rust/pl011/src/device.rs | 531 ++++++++++++++++++++++++++++++ > > > rust/pl011/src/device_class.rs | 95 ++++++ > > > rust/pl011/src/generated.rs | 5 + > > > rust/pl011/src/lib.rs | 575 +++++++++++++++++++++++++++++++++ > > > rust/pl011/src/memory_ops.rs | 38 +++ > > > > My thought is that if we're going to start implementing devices > > or other parts of QEMU, in Rust, then I do not want to see it > > placed in a completely separate directory sub-tree. > > > > In this example, I would expect to have hw/arm/pl011.rs, or hw/arm/pl011/*.rs > > so that the device is part of the normal Arm hardware directory structure > > and maintainer assignments. > > I think that's incompatible with the layout that Cargo expects. > rust/hw/arm/pl011/ could be another possibility. It doesn't look like its a problem in this patch series. It is just introducing a "rust/pl011/Cargo.toml", and I don't see anything that has an fundamental assumption that it is below a 'rust/' top level dir, as opposed to under our existing dir structure. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|