From: Nicolin Chen <nicolinc@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: <peter.maydell@linaro.org>, <wangxingang5@huawei.com>,
<shannon.zhaosl@gmail.com>, <imammedo@redhat.com>,
<anisinha@redhat.com>, <qemu-arm@nongnu.org>,
<qemu-devel@nongnu.org>
Subject: Re: [PATCH v3] hw/arm/virt-acpi-build: Fix id_count in build_iort_id_mapping
Date: Tue, 18 Jun 2024 14:19:25 -0700 [thread overview]
Message-ID: <ZnH53Qaqp5+Xo1jo@Asurada-Nvidia> (raw)
In-Reply-To: <20240618171311-mutt-send-email-mst@kernel.org>
On Tue, Jun 18, 2024 at 05:14:32PM -0400, Michael S. Tsirkin wrote:
> > @@ -306,8 +314,8 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> > }
> >
> > /* Append the last RC -> ITS ID mapping */
> > - if (next_range.input_base < 0xFFFF) {
> > - next_range.id_count = 0xFFFF - next_range.input_base;
> > + if (next_range.input_base < 0x10000) {
> > + next_range.id_count = 0x10000 - next_range.input_base;
> > g_array_append_val(its_idmaps, next_range);
> > }
>
> A change of logic here - I think the new one is right and old
> one was wrong, actually. Right?
Sorry, I don't quite follow that question...
Doesn't a patch correct an old wrong one to a new right one?
Thanks
Nicolin
next prev parent reply other threads:[~2024-06-18 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 21:11 [PATCH v3] hw/arm/virt-acpi-build: Fix id_count in build_iort_id_mapping Nicolin Chen
2024-06-18 21:14 ` Michael S. Tsirkin
2024-06-18 21:19 ` Nicolin Chen [this message]
2024-06-18 21:34 ` Michael S. Tsirkin
2024-06-18 21:51 ` Nicolin Chen
2024-06-18 22:05 ` Michael S. Tsirkin
2024-06-19 14:15 ` Eric Auger
2024-06-19 19:56 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnH53Qaqp5+Xo1jo@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wangxingang5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).